allow splitting withdrawal txs#4384
Merged
rigelrozanski merged 11 commits intocosmos:masterfrom May 23, 2019
Merged
Conversation
jleni
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alessio
reviewed
May 21, 2019
alessio
reviewed
May 21, 2019
alessio
reviewed
May 21, 2019
alessio
reviewed
May 21, 2019
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
alexanderbez
suggested changes
May 21, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
One minor nit, otherwise LGTM 👌
I may actually renege my statement on making this functionality only available to this command. Would you still be in favor of applying this to all commands?
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
alexanderbez
approved these changes
May 22, 2019
rigelrozanski
suggested changes
May 23, 2019
Contributor
rigelrozanski
left a comment
rigelrozanski
left a comment
There was a problem hiding this comment.
good changes! should tidy the code just a wee bit
jackzampolin
approved these changes
May 23, 2019
rigelrozanski
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to HSM limitations (Ledger Nano S), big transactions such as withdrawing rewards from a large number of validators, may be rejected to due memory constraints.
This PR introduces an additional flag that allows splitting the withdrawal messages and generates several transactions. Users can then define the maximum number of messages that they want to use.
This is related to: cosmos/ledger-cosmos#143
While we have extended limits to Nano X in the next release, it is important to provide an alternative to users of Nano S.
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: