Return account queries with height by colin-axner · Pull Request #4536 · cosmos/cosmos-sdk

colin-axner · 2019-06-11T18:29:02Z

closes: #4542

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry: clog add [section] [stanza] [message]
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

codecov · 2019-06-11T18:49:58Z

Codecov Report

Merging #4536 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4536   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files         256      256           
  Lines       16165    16165           
=======================================
  Hits         8648     8648           
  Misses       6870     6870           
  Partials      647      647

codecov · 2019-06-11T18:49:58Z

Codecov Report

Merging #4536 into master will increase coverage by <.01%.
The diff coverage is 10.34%.

@@            Coverage Diff            @@
##           master   #4536      +/-   ##
=========================================
+ Coverage   53.49%   53.5%   +<.01%     
=========================================
  Files         256     256              
  Lines       16165   16169       +4     
=========================================
+ Hits         8648    8651       +3     
- Misses       6870    6871       +1     
  Partials      647     647

alessio · 2019-06-11T19:45:28Z

Very good @colin-axner - how do you intend to test it?

colin-axner · 2019-06-11T20:27:45Z

@alessio I was planning on manually testing via initializing a rest-server and doing some queries on either mainnet or a testnet, but I don't have access to any nodes at the moment. Also it doesn't look like there are any good places in the codebase to add a test for this?

alexanderbez

ACK generally idea, but the logic needs to change slightly and we should add a LCD test 👍

x/auth/client/rest/query.go

client/context/query.go

alexanderbez

Thanks @colin-axner -- left a few more minor bits of feedback, but this looks great.

alexanderbez · 2019-06-12T11:25:14Z

client/context/query.go

 // queryStore performs a query from a Tendermint node with the provided a store
 // name and path.
-func (ctx CLIContext) queryStore(key cmn.HexBytes, storeName, endPath string) ([]byte, error) {
+func (ctx CLIContext) queryStore(key cmn.HexBytes, storeName, endPath string) ([]byte, int64, error) {


client/context/query.go

colin-axner · 2019-06-12T18:31:13Z

ACK generally idea, but the logic needs to change slightly and we should add a LCD test

Can the LCD test be contained in this module or would it need to be a separate package like in gaia?

alexanderbez · 2019-06-12T21:36:13Z

ACK generally idea, but the logic needs to change slightly and we should add a LCD test

Can the LCD test be contained in this module or would it need to be a separate package like in gaia?

ohhhhh since we moved LCD tests to gaia, this might be difficult to do. I wouldn't worry too much about testing then since all we're really doing is adding an extra return value.

alessio · 2019-06-13T08:43:46Z

x/auth/client/rest/query.go

 )

+// AccountWithHeight wraps the embedded Account
+// with the height it was queried at


Suggested change

// with the height it was queried at

// with the height it was queried at.

alexanderbez

ACK -- just one minor nitpick. Thanks @colin-axner!

alexanderbez · 2019-06-13T09:33:35Z

client/context/query.go

+// QueryWithData performs a query to a Tendermint node with the provided path
+// and a data payload. It returns the result and height of the query upon success
+// or an error if the query fails.
+func (ctx CLIContext) QueryWithData(path string, data []byte) ([]byte, int64, error) {


Hmmm, looks like QueryWithData is identical to Query! How about we simply remove QueryWithData?

fedekunze

LGTM

Addition to #4536, no longer specific to account queries. Allows for validator endpoints to return height in the response. Closes: #4609

return account queries with height

7997660

colin-axner requested review from alessio, alexanderbez, jackzampolin and rigelrozanski as code owners June 11, 2019 18:29

alessio requested a review from sabau June 11, 2019 18:34

alexanderbez added the ready-for-review label Jun 11, 2019

alexanderbez suggested changes Jun 11, 2019

View reviewed changes

x/auth/client/rest/query.go Outdated Show resolved Hide resolved

update clictx to return height on account query

ef7aede

fedekunze reviewed Jun 12, 2019

View reviewed changes

client/context/query.go Outdated Show resolved Hide resolved

alexanderbez reviewed Jun 12, 2019

View reviewed changes

client/context/query.go Outdated Show resolved Hide resolved

alexanderbez reviewed Jun 12, 2019

View reviewed changes

client/context/query.go Show resolved Hide resolved

alexanderbez suggested changes Jun 12, 2019

View reviewed changes

alexanderbez reviewed Jun 12, 2019

View reviewed changes

client/context/query.go Outdated Show resolved Hide resolved

colin-axner added 2 commits June 12, 2019 16:19

Query, QueryStore and QueryWithData return query height

02b4ad3

add pending log

c62439c

alessio reviewed Jun 13, 2019

View reviewed changes

alexanderbez approved these changes Jun 13, 2019

View reviewed changes

fedekunze approved these changes Jun 13, 2019

View reviewed changes

alexanderbez merged commit 95f3d32 into cosmos:master Jun 13, 2019

colin-axner mentioned this pull request Jun 17, 2019

R4R: generalize query response with height #4573

Merged

5 tasks

alessio pushed a commit that referenced this pull request Jul 1, 2019

generalize query response with height (#4573)

8d8fd9d

Addition to #4536, no longer specific to account queries. Allows for validator endpoints to return height in the response. Closes: #4609

This was referenced Oct 23, 2020

Follow up the new Cosmos REST spec medibloc/panacea-java#8

Closed

Follow up the new Cosmos REST spec medibloc/panacea-js#21

Closed

	// with the height it was queried at
	// with the height it was queried at.

Conversation

colin-axner commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 11, 2019

Codecov Report

Uh oh!

codecov bot commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alessio commented Jun 11, 2019

Uh oh!

colin-axner commented Jun 11, 2019

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderbez Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colin-axner commented Jun 12, 2019

Uh oh!

alexanderbez commented Jun 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alessio Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderbez Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

fedekunze left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

colin-axner commented Jun 11, 2019 •

edited

Loading

codecov bot commented Jun 11, 2019 •

edited

Loading

alexanderbez commented Jun 12, 2019 •

edited

Loading