fix undelegate losing tokens issue#4553
Merged
alexanderbez merged 2 commits intocosmos:masterfrom Jun 15, 2019
Merged
Conversation
helldealer
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4553 +/- ##
==========================================
- Coverage 53.47% 53.46% -0.02%
==========================================
Files 257 257
Lines 16168 16168
==========================================
- Hits 8646 8644 -2
- Misses 6876 6878 +2
Partials 646 646 |
alexanderbez
added
Type: Code Hygiene
fedekunze
approved these changes
Jun 14, 2019
Contributor
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
thanks for the fix! mind adding a clog entry too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the issue
Undelegate may lose the delegator’s tokens when exceed the MaxEntries of unbonding delegations #4551