Remove client/input.{Buffer,Override}Stdin() functions by alessio · Pull Request #4602 · cosmos/cosmos-sdk

alessio · 2019-06-20T14:09:00Z

Thanks: @jleni for the patch.

Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry: clog add [section] [stanza] [message]
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

codecov · 2019-06-20T14:31:51Z

Codecov Report

Merging #4602 into master will decrease coverage by 0.01%.
The diff coverage is 57.57%.

@@            Coverage Diff             @@
##           master    #4602      +/-   ##
==========================================
- Coverage   52.79%   52.78%   -0.02%     
==========================================
  Files         264      264              
  Lines       16468    16466       -2     
==========================================
- Hits         8695     8691       -4     
- Misses       7126     7128       +2     
  Partials      647      647

Cobra's new release made them redundant. Thanks: Juan Leni <juan.leni@zondax.ch> for the original patch.

alexanderbez

ACK -- Can you quickly test/play with this on Gaia @alessio ?

client/keys/add.go

sabau

LGTM is it now happy on gaia?

alessio · 2019-06-21T15:02:51Z

No, it isn't. There is one particular test case (TestGaiaCLIConfirmTx) that needs rewriting. I reckon it does not make sense to block this PR because of that, considering that all cli tests will have to be rewritten anyway.

sabau · 2019-06-21T15:04:43Z

Ok, we can open a PR/issue on gaia related to this

alessio · 2019-06-21T16:28:44Z

Tests pass now: cosmos/gaia#52

fedekunze · 2019-06-21T16:34:08Z

go.sum

 github.com/rcrowley/go-metrics v0.0.0-20180503174638-e2704e165165/go.mod h1:bCqnVzQkZxMG4s8nGwiZ5l3QUCyqpo9Y+/ZMZ9VjZe4=
 github.com/rs/cors v1.6.0 h1:G9tHG9lebljV9mfp9SNPDL36nCDxmo3zTlAf1YgvzmI=
 github.com/rs/cors v1.6.0/go.mod h1:gFx+x8UowdsKA9AchylcLynDq+nNFfI8FkUZdN/jGCU=
+github.com/russross/blackfriday v1.5.2/go.mod h1:JO/DiYxRf+HjHt06OyowR9PTA263kcR/rfWxYHBV53g=


fedekunze · 2019-06-21T16:34:40Z

go.sum

 github.com/aead/siphash v1.0.1/go.mod h1:Nywa3cDsYNNK3gaciGTWPwHt0wlpNV15vwmswBAUSII=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
 github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
+github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=


fedekunze · 2019-06-21T16:35:53Z

go.sum

-github.com/spf13/cobra v0.0.3/go.mod h1:1l0Ry5zgKvJasoi3XT1TypsSe7PqH0Sj9dhYf7v3XqQ=
+github.com/spf13/cobra v0.0.5 h1:f0B+LkLX6DtmRH1isoNA9VTtNUK9K8xYd28JNNfOv/s=
+github.com/spf13/cobra v0.0.5/go.mod h1:3K3wKZymM7VvHMDS9+Akkh4K60UwM26emMESw8tLCHU=
+github.com/spf13/jwalterweatherman v1.0.0/go.mod h1:cQK4TGJAtQXfYWX+Ddv3mKDzgVb68N+wFjFa4jdeBTo=


fedekunze · 2019-06-21T16:36:31Z

go.sum

 github.com/tendermint/iavl v0.12.2/go.mod h1:EoKMMv++tDOL5qKKVnoIqtVPshRrEPeJ0WsgDOLAauM=
 github.com/tendermint/tendermint v0.31.5 h1:vTet8tCq3B9/J9Yo11dNZ8pOB7NtSy++bVSfkP4KzR4=
 github.com/tendermint/tendermint v0.31.5/go.mod h1:ymcPyWblXCplCPQjbOYbrF1fWnpslATMVqiGgWbZrlc=
+github.com/ugorji/go/codec v0.0.0-20181204163529-d75b2dcb6bc8/go.mod h1:VFNgLljTbGfSG7qAOspJ7OScBnGdDN/yBr0sguwnwf0=


fedekunze · 2019-06-21T16:36:37Z

go.sum

 github.com/tendermint/tendermint v0.31.5 h1:vTet8tCq3B9/J9Yo11dNZ8pOB7NtSy++bVSfkP4KzR4=
 github.com/tendermint/tendermint v0.31.5/go.mod h1:ymcPyWblXCplCPQjbOYbrF1fWnpslATMVqiGgWbZrlc=
+github.com/ugorji/go/codec v0.0.0-20181204163529-d75b2dcb6bc8/go.mod h1:VFNgLljTbGfSG7qAOspJ7OScBnGdDN/yBr0sguwnwf0=
+github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q=


alessio · 2019-06-21T16:44:11Z

@fedekunze it appears that the new cobra depends on a bunch of additional packages. Can't do much to address your (legimitate) concerns

alessio · 2019-06-21T16:44:27Z

...other than reviewing the additional deps, of course

alexanderbez

ACK

As per changes introduced with cosmos/cosmos-sdk#4602

alessio force-pushed the alessio/upgrade-cobra branch from 2856f1d to 4b3f5ed Compare June 20, 2019 14:09

alessio changed the title ~~Alessio/upgrade cobra~~ Upgrade cobra to latest release Jun 20, 2019

Remove client/input.{Buffer,Override}Stdin() functions

2f09daa

Cobra's new release made them redundant. Thanks: Juan Leni <juan.leni@zondax.ch> for the original patch.

alessio force-pushed the alessio/upgrade-cobra branch from 4b3f5ed to 2f09daa Compare June 20, 2019 14:58

alessio changed the title ~~Upgrade cobra to latest release~~ Remove client/input.{Buffer,Override}Stdin() functions Jun 20, 2019

alessio marked this pull request as ready for review June 20, 2019 14:58

alessio requested review from alexanderbez, jackzampolin and rigelrozanski as code owners June 20, 2019 14:58

alessio requested review from fedekunze, jleni and sabau June 20, 2019 14:58

alexanderbez added the ready-for-review label Jun 20, 2019

alexanderbez reviewed Jun 20, 2019

View reviewed changes

alexanderbez added the C:CLI label Jun 20, 2019

sabau reviewed Jun 21, 2019

View reviewed changes

client/keys/add.go Show resolved Hide resolved

sabau approved these changes Jun 21, 2019

View reviewed changes

alessio pushed a commit to cosmos/gaia that referenced this pull request Jun 21, 2019

Testing cosmos/cosmos-sdk#4602

721466f

fedekunze reviewed Jun 21, 2019

View reviewed changes

alexanderbez approved these changes Jun 21, 2019

View reviewed changes

alessio merged commit 7b5e6ce into master Jun 22, 2019

alessio deleted the alessio/upgrade-cobra branch June 22, 2019 09:25

alessio mentioned this pull request Jun 22, 2019

upgrade to latest sdk cosmos/gaia#52

Merged

5 tasks

alessio pushed a commit to cosmos/gaia that referenced this pull request Jun 24, 2019

upgrade to latest sdk (#52)

0c12cce

As per changes introduced with cosmos/cosmos-sdk#4602

bchainexpt pushed a commit to bchainexpt/Blockchain-wallet-andorid-app that referenced this pull request Apr 4, 2022

upgrade to latest sdk (#52)

51bf887

As per changes introduced with cosmos/cosmos-sdk#4602

aurora-smith-ow09 added a commit to aurora-smith-ow09/fetchd that referenced this pull request Sep 27, 2025

upgrade to latest sdk (#52)

0f0923a

As per changes introduced with cosmos/cosmos-sdk#4602

Conversation

alessio commented Jun 20, 2019 • edited by alexanderbez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 20, 2019

Codecov Report

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sabau left a comment

Choose a reason for hiding this comment

Uh oh!

alessio commented Jun 21, 2019

Uh oh!

sabau commented Jun 21, 2019

Uh oh!

alessio commented Jun 21, 2019

Uh oh!

fedekunze Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

fedekunze Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

fedekunze Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

fedekunze Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

fedekunze Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

alessio commented Jun 21, 2019

Uh oh!

alessio commented Jun 21, 2019

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alessio commented Jun 20, 2019 •

edited by alexanderbez

Loading