update x/gov to match module spec#4665
Merged
alexanderbez merged 42 commits intomasterfrom Aug 8, 2019
Merged
Conversation
colin-axner
reviewed
Jul 2, 2019
golangcibot
reviewed
Jul 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #4665 +/- ##
==========================================
- Coverage 54.3% 54.04% -0.26%
==========================================
Files 271 269 -2
Lines 17344 17114 -230
==========================================
- Hits 9418 9249 -169
+ Misses 7228 7179 -49
+ Partials 698 686 -12 |
Contributor
Author
|
To introduce the Do we want to do that or should we leave it as is? @rigelrozanski @alexanderbez |
alexanderbez
suggested changes
Jul 25, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Blocking until review of proposal registration process
colin-axner
reviewed
Aug 7, 2019
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
alexanderbez
reviewed
Aug 7, 2019
colin-axner
approved these changes
Aug 7, 2019
rigelrozanski
approved these changes
Aug 7, 2019
Contributor
rigelrozanski
left a comment
rigelrozanski
left a comment
There was a problem hiding this comment.
Dopeness - much needed cleanup - left a few comments worth addressing
x/gov/keeper/proposal.go
Outdated
| return 0, types.ErrInvalidGenesis(keeper.codespace, "initial proposal ID hasn't been set") | ||
| } | ||
| keeper.cdc.MustUnmarshalBinaryLengthPrefixed(bz, &proposalID) | ||
| proposalID = binary.LittleEndian.Uint64(bz) |
Contributor
There was a problem hiding this comment.
This should be consolidated to a key function per my previous comments too
alexanderbez
suggested changes
Aug 8, 2019
alexanderbez
added
the
T: State Machine Breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: