Skip to content

Expose simapp genState generators and utils#4674

Merged
alexanderbez merged 4 commits intomasterfrom
export-sim-funcs
Jul 3, 2019
Merged

Expose simapp genState generators and utils#4674
alexanderbez merged 4 commits intomasterfrom
export-sim-funcs

Conversation

@fedekunze
Copy link
Copy Markdown
Contributor

@fedekunze fedekunze commented Jul 3, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jul 3, 2019
@fedekunze fedekunze marked this pull request as ready for review July 3, 2019 15:29
alexanderbez
alexanderbez approved these changes Jul 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2019

Codecov Report

Merging #4674 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4674      +/-   ##
==========================================
+ Coverage    54.8%   54.81%   +0.01%     
==========================================
  Files         269      269              
  Lines       16923    16923              
==========================================
+ Hits         9274     9276       +2     
+ Misses       6967     6965       -2     
  Partials      682      682

@alexanderbez alexanderbez merged commit 4e86810 into master Jul 3, 2019
@alexanderbez alexanderbez deleted the export-sim-funcs branch July 3, 2019 16:12
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@fedekunze @alexanderbez
Merge PR cosmos#4674: Expose simapp genState generators and utils
f110323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

1 more reviewer

@alexanderbez alexanderbez alexanderbez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fedekunze @alexanderbez