Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4906 +/- ##
==========================================
+ Coverage 53.63% 53.71% +0.07%
==========================================
Files 270 270
Lines 16982 16997 +15
==========================================
+ Hits 9109 9130 +21
+ Misses 7184 7178 -6
Partials 689 689 |
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
suggested changes
Aug 15, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Nice! Look's cleaner already. I just have a single bit of feedback 👍
alexanderbez
suggested changes
Aug 15, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Ran a few of the sims locally; non-determinism seems weird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: