Set proper default command output

[rmontagnin]

Description

This PR sets the proper default command output

closes: #8498

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[codecov]

Codecov Report

Merging #8628 (1ffa4ae) into master (82dc008) will increase coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head 1ffa4ae differs from pull request most recent head 9a60bda. Consider uploading reports for the commit 9a60bda to get more accurate results

@@            Coverage Diff             @@
##           master    #8628      +/-   ##
==========================================
+ Coverage   58.79%   58.83%   +0.03%     
==========================================
  Files         583      580       -3     
  Lines       32752    32636     -116     
==========================================
- Hits        19257    19200      -57     
+ Misses      11218    11170      -48     
+ Partials     2277     2266      -11     

Impacted Files	Coverage Δ
client/flags/flags.go	22.22% <ø> (+1.81%)	⬆️
client/keys/add.go	62.50% <ø> (-0.45%)	⬇️
client/keys/list.go	72.22% <ø> (-1.47%)	⬇️
client/keys/migrate.go	56.33% <0.00%> (ø)
version/command.go	83.33% <ø> (-0.67%)	⬇️
x/auth/client/cli/tx_sign.go	73.74% <ø> (-0.15%)	⬇️
x/auth/client/cli/validate_sigs.go	79.71% <0.00%> (ø)
x/feegrant/types/filtered_fee.go	0.00% <ø> (ø)
simapp/simd/cmd/root.go	62.30% <100.00%> (+0.58%)	⬆️
types/coin.go	93.11% <0.00%> (-0.16%)	⬇️
... and 7 more

[amaury1093]

lgtm, though I didn't test it. @RiccardoM did you test it locally on your machine?

Also, a changelog entry would be nice. I believe this is considered client-breaking.

[rmontagnin]

lgtm, though I didn't test it. @RiccardoM did you test it locally on your machine?

Also, a changelog entry would be nice. I believe this is considered client-breaking.

Added the CHANGELOG entry.

I also moved the place where the outputs were initialized cause it didn't work. The new method using the already existing PersistentPreRunE instead of PersistentPreRun now works properly.

[alessio]

Hold off please. Errors and diagnostics always go to stderr. When a command is meant to produce an output, that should go to stdout. Don't change defaults please.

[rmontagnin]

Hold off please. Errors and diagnostics always go to stderr. When a command is meant to produce an output, that should go to stdout. Don't change defaults please.

Shouldn't this be a responsibility of commands? IMO they should call cmd.PrintErrln() for errors, not cmd.Println. It would make more sense from my point of view to use the proper methods instead of having the default output to stderr

[alessio]

Hold off please. Errors and diagnostics always go to stderr. When a command is meant to produce an output, that should go to stdout. Don't change defaults please.

IMO they should call cmd.PrintErrln() for errors, not cmd.Println.

Yes, I agree. It makes sense. I agree with @alexanderbez, we need some grooming here. Just changing defaults seems the most obvious way to get the wrong solution in place.

[michaelfig]

It is unfortunate that this PR has not gained any traction. It is a major ergonomic failure (and violation of standard *nix pipelineable commands) to have machine-readable output go to stderr. If I run appd status | jq ..., the output is not captured. If I run appd status 2>&1 | jq ... then error messages are combined with the output and are hidden from view if there is a failure.

@alessio, what will it take to merge?

[alessio]

It is unfortunate that this PR has not gained any traction. It is a major ergonomic failure (and violation of standard *nix pipelineable commands) to have machine-readable output go to stderr. If I run appd status | jq ..., the output is not captured. If I run appd status 2>&1 | jq ... then error messages are combined with the output and are hidden from view if there is a failure.

@alessio, what will it take to merge?

I'm testing this again now.

[alessio]

@RiccardoM mind resolving the conflicts, please?

[rmontagnin]

@RiccardoM mind resolving the conflicts, please?

Should be done

[amaury1093]

tACK. Tested with a couple of CLI subcommands outputting JSON, and piping to jq

[amaury1093]

I believe backporting this could be useful for gaia CLI users.

[shahankhatch]

Thanks! Very helpful for gaia users.

[michaelfig]

Thank you, everybody!