fix(statemachine)!: 04-channel SendPacket now correctly returns ErrClientNotFound in favour of ErrConsensusStateNotFound (#3593) (#3598)

mergify[bot] · damiannolan · web-flow · commit 3a593b2d0187 · 2023-05-17T12:33:05.000+02:00
(cherry picked from commit 1f323ce) Co-authored-by: Damian Nolan <damiannolan@gmail.com>
diff --git a/modules/core/04-channel/keeper/packet.go b/modules/core/04-channel/keeper/packet.go
@@ -67,7 +67,7 @@ func (k Keeper) SendPacket(
 
 	clientState, found := k.clientKeeper.GetClientState(ctx, connectionEnd.GetClientID())
 	if !found {
-		return 0, clienttypes.ErrConsensusStateNotFound
+		return 0, clienttypes.ErrClientNotFound
 	}
 
 	// prevent accidental sends with clients that cannot be updated

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ func (k Keeper) SendPacket(`
`67`	`67`
`68`	`68`	`clientState, found := k.clientKeeper.GetClientState(ctx, connectionEnd.GetClientID())`
`69`	`69`	`if !found {`
`70`		`- return 0, clienttypes.ErrConsensusStateNotFound`
	`70`	`+ return 0, clienttypes.ErrClientNotFound`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`// prevent accidental sends with clients that cannot be updated`