Skip to content

Commit e6578fa

Browse files
jjjike2021gjermundgaraba
jjjike2021
and
gjermundgaraba
authored
chore(all): remove copy of the 'for' variable (#8195)
* fix * save * fix all --------- Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
1 parent e1eb033 commit e6578fa

File tree

127 files changed

+13
-561
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

127 files changed

+13
-561
lines changed

‎modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenInit() {
171171

172172
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
173173
for _, tc := range testCases {
174-
tc := tc
175-
176174
suite.Run(tc.name, func() {
177175
suite.SetupTest() // reset
178176
isNilApp = false
@@ -326,8 +324,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenAck() {
326324

327325
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
328326
for _, tc := range testCases {
329-
tc := tc
330-
331327
suite.Run(tc.name, func() {
332328
suite.SetupTest() // reset
333329
isNilApp = false
@@ -455,8 +451,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanCloseConfirm() {
455451

456452
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
457453
for _, tc := range testCases {
458-
tc := tc
459-
460454
suite.Run(tc.name, func() {
461455
suite.SetupTest() // reset
462456
isNilApp = false
@@ -502,8 +496,6 @@ func (suite *InterchainAccountsTestSuite) TestOnRecvPacket() {
502496

503497
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
504498
for _, tc := range testCases {
505-
tc := tc
506-
507499
suite.Run(tc.name, func() {
508500
suite.SetupTest() // reset
509501

@@ -600,8 +592,6 @@ func (suite *InterchainAccountsTestSuite) TestOnAcknowledgementPacket() {
600592

601593
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
602594
for _, tc := range testCases {
603-
tc := tc
604-
605595
suite.Run(tc.msg, func() {
606596
suite.SetupTest() // reset
607597
isNilApp = false
@@ -694,8 +684,6 @@ func (suite *InterchainAccountsTestSuite) TestOnTimeoutPacket() {
694684

695685
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
696686
for _, tc := range testCases {
697-
tc := tc
698-
699687
suite.Run(tc.msg, func() {
700688
suite.SetupTest() // reset
701689
isNilApp = false
@@ -756,8 +744,6 @@ func (suite *InterchainAccountsTestSuite) TestSingleHostMultipleControllers() {
756744

757745
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
758746
for _, tc := range testCases {
759-
tc := tc
760-
761747
suite.Run(tc.msg, func() {
762748
// reset
763749
suite.SetupTest()

‎modules/apps/27-interchain-accounts/controller/keeper/account_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ func (suite *KeeperTestSuite) TestRegisterInterchainAccount() {
5555
}
5656

5757
for _, tc := range testCases {
58-
tc := tc
59-
6058
suite.Run(tc.name, func() {
6159
suite.SetupTest()
6260

‎modules/apps/27-interchain-accounts/controller/keeper/genesis_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ func (suite *KeeperTestSuite) TestInitGenesis() {
4747
Ports: ports,
4848
}
4949
for _, tc := range testCases {
50-
tc := tc
51-
5250
suite.Run(tc.name, func() {
5351
suite.SetupTest()
5452

‎modules/apps/27-interchain-accounts/controller/keeper/grpc_query_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ func (suite *KeeperTestSuite) TestQueryInterchainAccount() {
4444

4545
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
4646
for _, tc := range testCases {
47-
tc := tc
48-
4947
suite.Run(tc.name, func() {
5048
suite.SetupTest()
5149

‎modules/apps/27-interchain-accounts/controller/keeper/handshake_test.go‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,6 @@ func (suite *KeeperTestSuite) TestOnChanOpenInit() {
238238
}
239239

240240
for _, tc := range testCases {
241-
tc := tc
242-
243241
suite.Run(tc.name, func() {
244242
suite.SetupTest() // reset
245243

@@ -399,8 +397,6 @@ func (suite *KeeperTestSuite) TestOnChanOpenAck() {
399397

400398
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
401399
for _, tc := range testCases {
402-
tc := tc
403-
404400
suite.Run(tc.name, func() {
405401
suite.SetupTest() // reset
406402

@@ -463,8 +459,6 @@ func (suite *KeeperTestSuite) TestOnChanCloseConfirm() {
463459

464460
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
465461
for _, tc := range testCases {
466-
tc := tc
467-
468462
suite.Run(tc.name, func() {
469463
suite.SetupTest() // reset
470464

‎modules/apps/27-interchain-accounts/controller/keeper/keeper_test.go‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func (suite *KeeperTestSuite) TestNewKeeper() {
140140
}
141141

142142
for _, tc := range testCases {
143-
tc := tc
143+
144144
suite.SetupTest()
145145

146146
suite.Run(tc.name, func() {
@@ -317,8 +317,6 @@ func (suite *KeeperTestSuite) TestSetAndGetParams() {
317317
}
318318

319319
for _, tc := range testCases {
320-
tc := tc
321-
322320
suite.Run(tc.name, func() {
323321
suite.SetupTest() // reset
324322
ctx := suite.chainA.GetContext()

‎modules/apps/27-interchain-accounts/controller/keeper/migrations_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ func (suite *KeeperTestSuite) TestMigratorMigrateParams() {
4242
}
4343

4444
for _, tc := range testCases {
45-
tc := tc
46-
4745
suite.Run(fmt.Sprintf("case %s", tc.msg), func() {
4846
suite.SetupTest() // reset
4947

‎modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ func (suite *KeeperTestSuite) TestRegisterInterchainAccount_MsgServer() {
6767

6868
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
6969
for _, tc := range testCases {
70-
tc := tc
71-
7270
suite.Run(tc.name, func() {
7371
expectedOrderding = ordering
7472

@@ -147,8 +145,6 @@ func (suite *KeeperTestSuite) TestSubmitTx() {
147145

148146
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
149147
for _, tc := range testCases {
150-
tc := tc
151-
152148
suite.Run(tc.name, func() {
153149
suite.SetupTest()
154150

@@ -241,8 +237,6 @@ func (suite *KeeperTestSuite) TestUpdateParams() {
241237
}
242238

243239
for _, tc := range testCases {
244-
tc := tc
245-
246240
suite.Run(tc.name, func() {
247241
suite.SetupTest()
248242
_, err := suite.chainA.GetSimApp().ICAControllerKeeper.UpdateParams(suite.chainA.GetContext(), tc.msg)

‎modules/apps/27-interchain-accounts/controller/keeper/relay_test.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,6 @@ func (suite *KeeperTestSuite) TestSendTx() {
142142

143143
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
144144
for _, tc := range testCases {
145-
tc := tc
146-
147145
suite.Run(tc.msg, func() {
148146
suite.SetupTest() // reset
149147
timeoutTimestamp = ^uint64(0) // default
@@ -186,8 +184,6 @@ func (suite *KeeperTestSuite) TestOnTimeoutPacket() {
186184

187185
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
188186
for _, tc := range testCases {
189-
tc := tc
190-
191187
suite.Run(tc.msg, func() {
192188
suite.SetupTest() // reset
193189

‎modules/apps/27-interchain-accounts/controller/types/codec_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ func TestCodecTypeRegistration(t *testing.T) {
4343
}
4444

4545
for _, tc := range testCases {
46-
tc := tc
47-
4846
t.Run(tc.name, func(t *testing.T) {
4947
encodingCfg := moduletestutil.MakeTestEncodingConfig(ica.AppModuleBasic{})
5048
msg, err := encodingCfg.Codec.InterfaceRegistry().Resolve(tc.typeURL)

0 commit comments

Comments
 (0)