From e92faec59659ae85c2e62c48668d214df850aa7b Mon Sep 17 00:00:00 2001 From: Aleksei Sviridkin Date: Fri, 7 Aug 2026 12:51:04 +0300 Subject: [PATCH] fix(scripts): make .PHONY in package.mk an actual declaration Line 2 used `.PHONY=`, which is a variable assignment. Make defined a variable that nothing reads, and none of the listed targets was phony. The special target needs a colon. Line 1 is `.DEFAULT_GOAL=help`, a real variable where `=` is correct, which is likely why this went unnoticed. Corrected the list to what this file actually defines. `suspend`, `resume`, `check` and `clean` were missing; `check` is the prerequisite that keeps `show`, `diff`, `apply` and `delete` rebuilding. Dropped `update` and `image`, which are defined neither here nor in any package Makefile: naming an undefined target in `.PHONY` creates it empty, so `make image` would report nothing to be done and exit 0 instead of failing with "No rule to make target". Assisted-By: Claude Signed-off-by: Aleksei Sviridkin --- scripts/package.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package.mk b/scripts/package.mk index cf0f5b7..2e3e903 100644 --- a/scripts/package.mk +++ b/scripts/package.mk @@ -1,5 +1,5 @@ .DEFAULT_GOAL=help -.PHONY=help show diff apply delete update image +.PHONY: help show diff apply delete suspend resume check clean help: ## Show this help. @awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {sub("\\\\n",sprintf("\n%22c"," "), $$2);printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)