feat: add startcollector management command for new collectors#226
Merged
wpak-ai merged 3 commits intoMay 21, 2026
Merged
Conversation
… guide Introduce `startcollector` to generate new collector apps (models, services, management command, tests, schedule snippet) with CI validation via validate_collector_scaffold.py. Document the workflow and service-layer rules in root CONTRIBUTING.md and update doc links across the repo. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core/management/commands/startcollector.py`:
- Around line 375-377: The collision check in _validate_app_label builds
installed from settings.INSTALLED_APPS by filtering out entries containing ".",
which ignores dotted app-config entries and allows collisions; change the logic
that constructs the installed set (the variable named installed in
startcollector.py) to normalize entries by extracting the actual app
package/name from dotted strings (e.g., split on "." and take the first segment
or otherwise derive the app label) so both plain and dotted entries are
considered when checking if app_label is in installed; update the check that
raises CommandError to use this normalized installed set.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b507791f-a8e0-4a9d-991c-c03eaccca472
📒 Files selected for processing (16)
.github/workflows/actions.yml.gitignoreCONTRIBUTING.mdREADME.mdcore/README.mdcore/management/commands/startcollector.pycore/tests/test_startcollector.pydocs/How_to_add_a_collector.mddocs/Service_API.mddocs/service_api/boost_library_tracker.mddocs/service_api/boost_mailing_list_tracker.mddocs/service_api/core_protocols.mddocs/service_api/cppa_slack_tracker.mddocs/service_api/wg21_paper_tracker.mdscripts/generate_service_docs.pyscripts/validate_collector_scaffold.py
leostar0412
requested review from
jonathanMLDev,
snowfox1003 and
wpak-ai
as code owners
jonathanMLDev
approved these changes
May 21, 2026
wpak-ai
approved these changes
May 21, 2026
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python manage.py startcollector <app_label>to generate a new collector Django app with the standard layout: stubmodels.py/services.py,run_<app>usingAbstractCollector+BaseCollectorCommand,tests/package,migrations/0001_initial.py, and a commentedschedule_snippet.yamlforconfig/boost_collector_schedule.yaml.--dry-run,--path(for tests/CI), validation of app labels (snake_case, reserved names, collisions withINSTALLED_APPSor existing paths).scripts/validate_collector_scaffold.pyand a pyright workflow step that scaffolds a throwaway app under.test_artifacts/and runs ruff + scoped pyright on the generated tree.core/tests/test_startcollector.pycover dry-run, validation errors, and expected file layout.Test plan
python manage.py startcollector my_test_app --dry-run(no files written; preview looks correct)python manage.py startcollector my_test_appin a temp directory or throwaway path; confirm layout matches existing collectors (AbstractCollector, noCollectorBase)pytest core/tests/test_startcollector.py -vpython scripts/validate_collector_scaffold.py(same check as CI pyright job)Closes #214
Summary by CodeRabbit
New Features
Documentation
Tests
Chores