ironic: Install deploy image with ironic#2100
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| ramdisk_image_prefix = "ir-deploy-ramdisk" | ||
| image_path = "/srv/tftpboot/openstack-ironic-image" | ||
|
|
||
| image_version_env = "IMAGE_VERSION=$(readlink #{image_path}/vmlinux | egrep -o '[0-9]+\\.[0-9]+\\.[0-9]+' | head -n1)" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [118/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
There was a problem hiding this comment.
This would work so as long as the file naming convention stayed the same.
|
Versioning of images in glance added. |
| ramdisk_image_prefix = "ir-deploy-ramdisk" | ||
| image_path = "/srv/tftpboot/openstack-ironic-image" | ||
|
|
||
| image_version_env = "IMAGE_VERSION=$(readlink #{image_path}/vmlinux | egrep -o '[0-9]+\\.[0-9]+\\.[0-9]+' | head -n1)" |
There was a problem hiding this comment.
This would work so as long as the file naming convention stayed the same.
| env << "OS_PROJECT_NAME='#{keystone_settings["service_tenant"]}' " | ||
| env << "OS_AUTH_URL='#{keystone_settings["internal_auth_url"]}' " | ||
| env << "OS_INTERFACE=internal " | ||
| env << "OS_IDENTITY_API_VERSION=3 " |
There was a problem hiding this comment.
Don't we need the domain as well? Like OS_DEFAULT_DOMAIN=#{keystone_settings["admin_domain"]}
There was a problem hiding this comment.
I'm not sure. There are at least a couple of places which didn't set this (e.g. glance/recipes/setup.rb).
| env << "OS_INTERFACE=internal " | ||
| env << "OS_IDENTITY_API_VERSION=3 " | ||
|
|
||
| kernel_image_prefix = "ir-deploy-kernel" |
There was a problem hiding this comment.
Can we name this ironic-deploy-kernel ? ir might be a bit cryptic. Or is there some length limitation?
There was a problem hiding this comment.
This was changed based on Ardana naming.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I think we should keep the names consistent with Ardana to avoid further confusion.
| env << "OS_IDENTITY_API_VERSION=3 " | ||
|
|
||
| kernel_image_prefix = "ir-deploy-kernel" | ||
| ramdisk_image_prefix = "ir-deploy-ramdisk" |
The official SUSE deploy image package will be installed by default together with ironic-server role. Kernel and ramdisk images will be uploaded to glance.
| # This is to trigger the above resource to run :delayed, so that they run at | ||
| # the end of the chef-client run, after the ironic services have been restarted | ||
| # (in case of a config change) | ||
| execute "trigger-ironic-post-commands" do |
There was a problem hiding this comment.
Is this tested with HA? What if 3 cluster nodes want to upload the image at the same time?
There was a problem hiding this comment.
Current ironic barclamp doesn't support HA (i.e. you can't assign role to cluster, only to single node).
4 participants
The official SUSE deploy image package will be installed by default
together with ironic-server role. Kernel and ramdisk images will be
uploaded to glance.