Merge pull request #64 from cryptocoinjs/fixArrayLike

Allow Array and Uint8Array like 3.0.4

Author: junderw

src/index.d.ts

@@ -3,7 +3,7 @@ declare function base(ALPHABET: string): base.BaseConverter;
 export = base;
 declare namespace base {
     interface BaseConverter {
-        encode(buffer: Buffer): string;
+        encode(buffer: Buffer | number[] | Uint8Array): string;
         decodeUnsafe(string: string): Buffer | undefined;
         decode(string: string): Buffer;
     }

src/index.js

@@ -23,6 +23,7 @@ function base (ALPHABET) {
   var FACTOR = Math.log(BASE) / Math.log(256) // log(BASE) / log(256), rounded up
   var iFACTOR = Math.log(256) / Math.log(BASE) // log(256) / log(BASE), rounded up
   function encode (source) {
+    if (Array.isArray(source) || source instanceof Uint8Array) { source = _Buffer.from(source) }
     if (!_Buffer.isBuffer(source)) { throw new TypeError('Expected Buffer') }
     if (source.length === 0) { return '' }
         // Skip & count leading zeroes.

test/index.js

@@ -55,3 +55,11 @@ tape.test('encode throws on string', function (t) {
     base.encode('a')
   }, new RegExp('^TypeError: Expected Buffer$'))
 })
+
+tape.test('encode not throw on Array or Uint8Array', function (t) {
+  var base = bases.base58
+
+  t.plan(2)
+  t.same(base.encode([42, 12, 34]), 'F89f')
+  t.same(base.encode(new Uint8Array([42, 12, 34])), 'F89f')
+})

ts_src/index.ts

@@ -28,7 +28,8 @@ function base (ALPHABET: string): base.BaseConverter {
   const FACTOR = Math.log(BASE) / Math.log(256) // log(BASE) / log(256), rounded up
   const iFACTOR = Math.log(256) / Math.log(BASE) // log(256) / log(BASE), rounded up
 
-  function encode (source: Buffer): string {
+  function encode (source: Buffer | number[] | Uint8Array): string {
+    if (Array.isArray(source) || source instanceof Uint8Array) source = _Buffer.from(source)
     if (!_Buffer.isBuffer(source)) throw new TypeError('Expected Buffer')
     if (source.length === 0) return ''
 
@@ -156,7 +157,7 @@ export = base;
 
 declare namespace base {
     interface BaseConverter {
-        encode(buffer: Buffer): string;
+        encode(buffer: Buffer | number[] | Uint8Array): string;
         decodeUnsafe(string: string): Buffer | undefined;
         decode(string: string): Buffer;
     }