Skip to content

Commit eb544c0

Browse files
author
Carlos Scheidegger
committed
bugfix
1 parent 3d8fd5a commit eb544c0

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/shade/scale/ordinal.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ Shade.Scale.ordinal = function(opts)
1010
if (!(opts.range.length >= 2)) {
1111
throw "Shade.Scale.ordinal requires arrays of length at least 2";
1212
}
13-
opts.range = _.map(opts.range, Shade.make);
14-
var range_types = _.map(opts.range, function(v) { return v.type; });
13+
var range = _.map(opts.range, Shade.make);
14+
var range_types = _.map(range, function(v) { return v.type; });
1515
if (!all_same(range_types))
1616
throw "Shade.Scale.linear requires range elements to have the same type";
1717

18-
var choose = Shade.Utils.choose(range_types);
18+
var choose = Shade.Utils.choose(range);
1919

2020
return function(v) {
2121
return choose(v.as_float().add(0.5));

tests/tests.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -872,6 +872,15 @@ test("Shade.evaluate()", function() {
872872
equal(Shade(v1).sin().cos().evaluate(), Math.cos(Math.sin(6)));
873873
});
874874

875+
test("Shade.scale.*", function() {
876+
var t1 = Shade.Scale.ordinal({
877+
range: [Shade.color("green"),
878+
Shade.color("red"),
879+
Shade.color("blue"),
880+
Shade.color("black"),
881+
Shade.color("yellow")]});
882+
});
883+
875884
module("Facet tests");
876885
test("Facet.attribute_buffer", function() {
877886
ok(Facet.attribute_buffer({ vertex_array: [1,2,3,4], item_size: 1}));

0 commit comments

Comments
 (0)