update

Author: marc-farre

docs/CHANGELOG.md

@@ -1,9 +1,10 @@
 Changelog
 =========
 
-Unreleased
+1.2.4 (February 25, 2023)
 --------------------
 - Fix: Don't add to group a user that is not active
+- Fix: PHP 8.1 warning in the module settings if empty values
 
 1.2.3 (February 20, 2023)
 --------------------

models/ConfigureForm.php

@@ -244,11 +244,11 @@ public function save()
         $module = Yii::$app->getModule('auth-keycloak');
 
         $module->settings->set('enabled', $this->enabled);
-        $module->settings->set('clientId', trim($this->clientId));
-        $module->settings->set('clientSecret', trim($this->clientSecret));
-        $module->settings->set('realm', trim($this->realm));
-        $module->settings->set('baseUrl', rtrim(trim($this->baseUrl), '/'));
-        $module->settings->set('usernameMapper', trim($this->usernameMapper));
+        $module->settings->set('clientId', trim((string)$this->clientId));
+        $module->settings->set('clientSecret', trim((string)$this->clientSecret));
+        $module->settings->set('realm', trim((string)$this->realm));
+        $module->settings->set('baseUrl', rtrim(trim((string)$this->baseUrl), '/'));
+        $module->settings->set('usernameMapper', trim((string)$this->usernameMapper));
         if (!$this->title) {
             $this->title = static::DEFAULT_TITLE;
         }

module.json

@@ -3,7 +3,7 @@
     "name": "Keycloak Sign-In",
     "description": "Integrating Keycloak Sign-In (OAuth 2.0)",
     "keywords": ["auth", "keycloak"],
-    "version": "1.2.3",
+    "version": "1.2.4",
     "humhub": {
         "minVersion": "1.12"
     },