Skip to content

Commit 01ff815

Browse files
nmueschDavid Bouchare
authored andcommitted
Revert "Return Rate Limit Headers (DataDog#378)"
This reverts commit 0c1365d.
1 parent d48ceca commit 01ff815

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

datadog/api/api_client.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ def submit(cls, method, path, api_version=None, body=None, attach_host_name=Fals
141141

142142
# Format response content
143143
content = result.content
144-
response_headers = result.headers
145144

146145
if content:
147146
try:
@@ -156,10 +155,6 @@ def submit(cls, method, path, api_version=None, body=None, attach_host_name=Fals
156155
raise ApiError(response_obj)
157156
else:
158157
response_obj = None
159-
160-
if response_obj:
161-
response_obj['response_headers'] = response_headers
162-
163158
if response_formatter is None:
164159
return response_obj
165160
else:

tests/integration/api/test_api.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
FAKE_PROXY = {
2828
"https": "http://user:pass@10.10.1.10:3128/",
2929
}
30-
RATE_LIMIT_HEADERS = ['X-RateLimit-Limit', 'X-RateLimit-Period', 'X-RateLimit-Reset', 'X-RateLimit-Remaining']
3130

3231

3332
class TestDatadog(unittest.TestCase):
@@ -363,26 +362,6 @@ def test_metrics(self):
363362

364363
dog.Metric.send(metric='matt.metric', points=matt_series, host="matt.metric.host")
365364

366-
@attr("metric")
367-
def test_rate_limit_headers(self):
368-
now = datetime.datetime.now()
369-
now_ts = int(time.mktime(now.timetuple()))
370-
metric_name = "test.metric." + str(now_ts)
371-
host_name = "test.host." + str(now_ts)
372-
373-
dog.Metric.send(metric=metric_name, points=1, host=host_name)
374-
time.sleep(self.wait_time)
375-
376-
metric_query = dog.Metric.query(start=now_ts - 3600, end=now_ts + 3600,
377-
query="avg:%s{host:%s}" % (metric_name, host_name))
378-
assert len(metric_query['series']) == 1, metric_query
379-
380-
headers = metric_query.get('response_headers')
381-
assert headers
382-
383-
for header in RATE_LIMIT_HEADERS:
384-
assert header in headers
385-
386365
def test_type_check(self):
387366
dog.Metric.send(metric="test.metric", points=[(time.time() - 3600, 1.0)])
388367
dog.Metric.send(metric="test.metric", points=1.0)

0 commit comments

Comments
 (0)