[#36204] Add new GitHub plugin tab enabling users to copy git actions (opf#9027)

* Let GitHub integration show changes in a separate tab

* added new github integration icons to icon font
* add tab content:  working tab-header and copy-menu

* modernise github_integrations ruby code

* refactored some code to be more modern ruby (if wrote most of it 7
  years ago and couldn't look at some parts without squinting too much)
* make some intended-to-be-private module methods actually private
* fixed all rubocop errors in the /modules/github_integration
* re-organized tests a little
* gave our rubocop.yml some RSpec-related defaults -- happy to discuss
  these, but I think we can live with these as a good starting point

👆 all without actually (intentionally) changing the behaviour

* removed dead angular template code

* codeclimate found more things than rubocop :)

* removed create-pr-button since we decided against implementing that feature

* added missing translations

* properly cache the github related part of the wp api

* lower case pull requests in translations

* fix specs

Author: Philipp Tessenow

.rubocop.yml

@@ -7,6 +7,12 @@ AllCops:
   Exclude:
     - db/schema.rb
 
+
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - modules/**/*.gemspec
+
+
 Layout/ConditionPosition:
   Enabled: false
 
@@ -282,5 +288,12 @@ Style/HashTransformKeys:
 Style/HashTransformValues:
   Enabled: true
 
-Rspec/MultipleMemoizedHelpers:
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 15
+
+RSpec/MultipleExpectations:
   Max: 15
+
+RSpec/ExampleLength:
+  Max: 25

docker/ci/entrypoint.sh

@@ -51,7 +51,7 @@ if [ "$1" == "setup-tests" ]; then
 	done
 
 	execute "time bundle install -j$JOBS"
-	execute "TEST_ENV_NUMBER=0 time bundle exec rake db:create db:migrate db:schema:dump webdrivers:chromedriver:update webdrivers:geckodriver:update"
+	execute "TEST_ENV_NUMBER=0 time bundle exec rake db:create db:migrate db:schema:dump webdrivers:chromedriver:update webdrivers:geckodriver:update openproject:plugins:register_frontend"
 	execute "time bundle exec rake parallel:create parallel:load_schema"
 fi
 

frontend/angular.json

@@ -88,7 +88,7 @@
           "builder": "@angular-devkit/build-angular:dev-server",
           "options": {
             "browserTarget": "OpenProject:build",
-            "proxyConfig": "cli_to_rails_proxy.js",
+            "proxyConfig": "cli_to_rails_proxy.js"
           },
           "configurations": {
             "production": {
@@ -105,6 +105,7 @@
         "test": {
           "builder": "@angular-devkit/build-angular:karma",
           "options": {
+            "preserveSymlinks": true,
             "main": "src/test.ts",
             "karmaConfig": "./karma.conf.js",
             "tsConfig": "src/tsconfig.spec.json",
@@ -124,7 +125,8 @@
             "lintFilePatterns": [
               "src/**/*.ts",
               "src/**/*.html"
-            ]
+            ],
+            "preserveSymlinks": true
           }
         }
       }

frontend/doc/TESTING.md

@@ -11,7 +11,7 @@ OpenProject is a hybrid application with most parts being Rails, along with some
 
 
 
-The  Angular frontend services and components can be tested with frontend specs. A good isolated example on how to set up an Angular TestBed to test components is `frontend/src/app/modules/a11y/accessible-by-keyboard.component.spec.ts`
+The Angular frontend services and components can be tested with frontend specs. A good isolated example on how to set up an Angular TestBed to test components is `frontend/src/app/modules/a11y/accessible-by-keyboard.component.spec.ts`
 
 
 

frontend/npm-shrinkwrap.json

@@ -77,6 +77,7 @@
     "chart.js": "2.9.3",
     "chartjs-plugin-datalabels": "^0.6.0",
     "codemirror": "^5.48.4",
+    "copy-text-to-clipboard": "^3.0.0",
     "core-js": "^3.2.1",
     "crossvent": "^1.5.4",
     "dom-autoscroller": "^2.2.8",
@@ -106,6 +107,7 @@
     "rxjs": "^6.6.6",
     "screenfull": "^4.2.1",
     "tablesorter": "^2.31.3",
+    "tickety-tick-formatter": "github:bitcrowd/tickety-tick-formatter",
     "typedjson": "^1.5.1",
     "typescript": "~4.1.2",
     "urijs": "^1.19.2",

frontend/package.json

@@ -59,7 +59,7 @@ describe('TimezoneService', function () {
       ]
     });
 
-    timezoneService = TestBed.get(TimezoneService);
+    timezoneService = TestBed.inject(TimezoneService);
   };
 
   describe('without time zone set', function () {

frontend/src/app/components/datetime/timezone.service.spec.ts

@@ -18,11 +18,11 @@ export abstract class OpContextMenuHandler extends UntilDestroyedMixin {
    * Called when the service closes this context menu
    */
   public onClose() {
-    this.afterFocusOn.focus();
+    this.afterFocusOn.trigger('focus');
   }
 
   public onOpen(menu:JQuery) {
-    menu.find('.menu-item').first().focus();
+    menu.find('.menu-item').first().trigger('focus');
   }
 
   /**

frontend/src/app/components/op-context-menu/op-context-menu-handler.ts

@@ -97,7 +97,7 @@ describe('WorkPackageFilterValues', () => {
       ]
     }).compileComponents();
 
-    injector = TestBed.get(Injector);
+    injector = TestBed.inject(Injector);
     halResourceService = injector.get(HalResourceService);
 
     resource = halResourceService.createHalResourceOfClass(WorkPackageResource, source, true);

frontend/src/app/components/wp-edit-form/work-package-filter-values.spec.ts

@@ -43,7 +43,7 @@ describe('BcfApiService', function () {
     })
       .compileComponents()
       .then(() => {
-        service = TestBed.get(BcfApiService);
+        service = TestBed.inject(BcfApiService);
       });
   }));