diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cd096884..a3c5e62f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,11 +11,7 @@ on: default: false permissions: - contents: write - issues: write - pull-requests: write - packages: write - id-token: write + contents: read concurrency: group: release-${{ github.ref }} @@ -190,6 +186,8 @@ jobs: name: Upload Release Assets needs: [release-please, build-binaries] runs-on: ubuntu-latest + permissions: + contents: write steps: - name: Generate GitHub App Token id: app-token diff --git a/.github/workflows/security-deep.yml b/.github/workflows/security-deep.yml index d133ae40..ee767ce8 100644 --- a/.github/workflows/security-deep.yml +++ b/.github/workflows/security-deep.yml @@ -11,7 +11,6 @@ concurrency: permissions: contents: read - security-events: write jobs: gitleaks-history: diff --git a/apps/rook/Dockerfile b/apps/rook/Dockerfile index 36043df6..d3d4c7ee 100644 --- a/apps/rook/Dockerfile +++ b/apps/rook/Dockerfile @@ -27,12 +27,10 @@ ARG TARGETARCH RUN echo "Target architecture: ${TARGETARCH}" COPY rook-${TARGETARCH} /usr/local/bin/rook -# Create config directory with proper permissions +# Create config directory with proper permissions and ensure binary is executable RUN mkdir -p /app/config \ - && chown -R rook:rook /app - -# Ensure binary is executable -RUN chmod +x /usr/local/bin/rook + && chown -R rook:rook /app \ + && chmod +x /usr/local/bin/rook USER rook diff --git a/apps/rook/build.rs b/apps/rook/build.rs index 74d12dc0..2106f291 100644 --- a/apps/rook/build.rs +++ b/apps/rook/build.rs @@ -28,16 +28,15 @@ fn main() { } else { let profile = std::env::var("PROFILE").unwrap_or_default(); if profile == "release" { - eprintln!( - "error: dashboard/node_modules/.bin/vite not found in release mode" - ); - eprintln!("hint: run `pnpm install` in the repo root before building release" - ); + eprintln!("error: dashboard/node_modules/.bin/vite not found in release mode"); + eprintln!("hint: run `pnpm install` in the repo root before building release"); std::process::exit(1); } println!( "cargo:warning=dashboard/node_modules/.bin/vite not found, skipping dashboard build" ); - println!("cargo:warning=hint: run `pnpm install` in the repo root to enable dashboard embedding"); + println!( + "cargo:warning=hint: run `pnpm install` in the repo root to enable dashboard embedding" + ); } } diff --git a/apps/rook/dashboard/playwright.config.ts b/apps/rook/dashboard/playwright.config.ts index 5ece9567..8f805e6b 100644 --- a/apps/rook/dashboard/playwright.config.ts +++ b/apps/rook/dashboard/playwright.config.ts @@ -1,12 +1,6 @@ import process from 'node:process' import { defineConfig, devices } from '@playwright/test' -/** - * Read environment variables from file. - * https://github.com/motdotla/dotenv - */ -// require('dotenv').config(); - /** * See https://playwright.dev/docs/test-configuration. */ diff --git a/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbEllipsis.vue b/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbEllipsis.vue index 9cc3a4f2..41d33d06 100644 --- a/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbEllipsis.vue +++ b/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbEllipsis.vue @@ -9,15 +9,13 @@ const props = defineProps<{ diff --git a/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbItem.vue b/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbItem.vue index e3dce685..37004943 100644 --- a/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbItem.vue +++ b/apps/rook/dashboard/src/components/ui/breadcrumb/BreadcrumbItem.vue @@ -9,6 +9,7 @@ const props = defineProps<{