From f0f56948d809a8bff92b5de3dde44d6f64aee6f7 Mon Sep 17 00:00:00 2001 From: xdustinface Date: Tue, 4 Aug 2020 03:02:22 +0200 Subject: [PATCH] llmq: Fix spork check in CSigSharesManager::ForceReAnnouncement It seems like the idea here was to avoid announcing already available sigshares for a signhash to everyone if concentrated recovery is enabled. But by returning there if `IsAllMembersConnectedEnabled` equals to `false` we disable the re-announcements prior to the spork activation, where we want to still have them and re-enable if the spork is enabled where we don't want to have them. --- src/llmq/quorums_signing_shares.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp index 5d42a1422156..92cfae4a2531 100644 --- a/src/llmq/quorums_signing_shares.cpp +++ b/src/llmq/quorums_signing_shares.cpp @@ -1609,7 +1609,7 @@ void CSigSharesManager::Sign(const CQuorumCPtr& quorum, const uint256& id, const // causes all known sigShares to be re-announced void CSigSharesManager::ForceReAnnouncement(const CQuorumCPtr& quorum, Consensus::LLMQType llmqType, const uint256& id, const uint256& msgHash) { - if (!CLLMQUtils::IsAllMembersConnectedEnabled(llmqType)) { + if (CLLMQUtils::IsAllMembersConnectedEnabled(llmqType)) { return; }