From c0cb338c557f7a4b6975af28ec4518cf82306ac1 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Tue, 3 Jun 2025 19:26:00 +0700 Subject: [PATCH] fix: intermittent error in p2p_invalid_block.py Mocktime here is misused here `t = int(time.time())` Functional test p2p_invalid_block.py is changed are adjusted for Dash Core --- test/functional/p2p_invalid_block.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/functional/p2p_invalid_block.py b/test/functional/p2p_invalid_block.py index 39b962734a7f..e4555dba9cf7 100755 --- a/test/functional/p2p_invalid_block.py +++ b/test/functional/p2p_invalid_block.py @@ -13,7 +13,6 @@ becomes valid. """ import copy -import time from test_framework.blocktools import MAX_FUTURE_BLOCK_TIME, create_block, create_coinbase, create_tx_with_script from test_framework.messages import COIN @@ -132,15 +131,14 @@ def run_test(self): peer.send_blocks_and_test([block4], node, success=False, reject_reason='bad-txns-inputs-duplicate') self.log.info("Test accepting identical block after rejecting it due to a future timestamp.") - t = int(time.time()) - node.setmocktime(t) + t = self.mocktime # Set block time +1 second past max future validity block = create_block(tip, create_coinbase(height), t + MAX_FUTURE_BLOCK_TIME + 1) block.hashMerkleRoot = block.calc_merkle_root() block.solve() # Need force_send because the block will get rejected without a getdata otherwise peer.send_blocks_and_test([block], node, force_send=True, success=False, reject_reason='time-too-new') - node.setmocktime(t + 1) + self.bump_mocktime(1) peer.send_blocks_and_test([block], node, success=True)