From daeac68c1542b3c3479b046626d75fc1f9ba0039 Mon Sep 17 00:00:00 2001 From: pankcuf Date: Fri, 14 Jul 2023 18:30:19 +0700 Subject: [PATCH] fix: limit protocol version support with upper bound --- DashSync/shared/Models/Network/DSPeer.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DashSync/shared/Models/Network/DSPeer.m b/DashSync/shared/Models/Network/DSPeer.m index fd975ff07..caee03c48 100644 --- a/DashSync/shared/Models/Network/DSPeer.m +++ b/DashSync/shared/Models/Network/DSPeer.m @@ -855,9 +855,9 @@ - (void)acceptVersionMessage:(NSData *)message { } _lastBlockHeight = [message UInt32AtOffset:80 + l.unsignedIntegerValue]; - if (self.version < self.chain.minProtocolVersion) { + if (self.version < self.chain.minProtocolVersion || self.version > self.chain.protocolVersion) { #if MESSAGE_LOGGING - DSLog(@"%@:%u protocol version %u not supported, useragent:\"%@\"", self.host, self.port, self.version, self.useragent); + DSLog(@"%@:%u protocol version %u not supported, valid versions are: [%u, %u], useragent:\"%@\", ", self.host, self.port, self.version, self.chain.minProtocolVersion, self.chain.protocolVersion, self.useragent); #endif [self error:@"protocol version %u not supported", self.version]; return;