From 6c55116a150a028420494a4ed9c23ae980699d78 Mon Sep 17 00:00:00 2001 From: thephez Date: Mon, 19 Feb 2024 10:47:50 -0500 Subject: [PATCH 1/2] docs(p2p): move islock to deprecated message type table Related to https://github.com/dashpay/dash/pull/5553 --- docs/reference/p2p-network-data-messages.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/reference/p2p-network-data-messages.md b/docs/reference/p2p-network-data-messages.md index 239a5bf9..e1f1142e 100644 --- a/docs/reference/p2p-network-data-messages.md +++ b/docs/reference/p2p-network-data-messages.md @@ -36,7 +36,6 @@ The currently-available type identifiers are: | 26 | MSG_QUORUM_PREMATURE_COMMITMENT | The hash is a long-living masternode quorum premature commitment.
_Added in 0.14.0_ | 28 | MSG_QUORUM_RECOVERED_SIG | The hash is a long-living masternode quorum recovered signature.

**Note**: Only relayed to other masternodes in the same quorum and nodes that have sent a [`qwatch` message](../reference/p2p-network-quorum-messages.md#qwatch) as of Dash Core 0.17.0
_Added in 0.14.0_ | 29 | MSG_CLSIG | The hash is a ChainLock signature.
_Added in 0.14.0_ -| 30 | MSG_ISLOCK | The hash is an LLMQ-based InstantSend lock ([DIP10](https://github.com/dashpay/dips/blob/master/dip-0010.md)).
_Added in 0.14.0_ | 31 | MSG_ISDLOCK | The hash is an LLMQ-based deterministic InstantSend lock ([DIP22](https://github.com/dashpay/dips/blob/master/dip-0022.md)).
_Added in 18.0_ **Deprecated Type Identifiers** @@ -45,8 +44,7 @@ The following type identifiers have been deprecated recently. To see type identi | Type Identifier | Name | Description |-----------------|-------------------------------------------------------------------------------|--------------- -| 4 | MSG_LEGACY_TXLOCK_REQUEST | **Deprecated in 20.0.0**

`MSG_TXLOCK_REQUEST` prior to Dash Core 0.15.0. The hash is an InstantSend transaction lock request. Transactions received this way are automatically converted to a standard [`tx` message](../reference/p2p-network-data-messages.md#tx) as of Dash Core 0.15.0. -| 5 | MSG_TXLOCK_VOTE | **Deprecated in 0.15.0**

The hash is an InstantSend transaction vote. +| 30 | MSG_ISLOCK | **Deprecated in 20.1.0**
The hash is an LLMQ-based InstantSend lock ([DIP10](https://github.com/dashpay/dips/blob/master/dip-0010.md)).
_Added in 0.14.0_ Type identifier zero and type identifiers greater than those shown in the table above are reserved for future implementations. Dash Core ignores all inventories with one of these unknown types. From 80c420ff538792724682bac34cc009605c144720 Mon Sep 17 00:00:00 2001 From: thephez Date: Mon, 19 Feb 2024 10:52:21 -0500 Subject: [PATCH 2/2] docs: minor table formatting --- docs/reference/p2p-network-data-messages.md | 44 +++++++++++---------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/docs/reference/p2p-network-data-messages.md b/docs/reference/p2p-network-data-messages.md index e1f1142e..b6a3f00c 100644 --- a/docs/reference/p2p-network-data-messages.md +++ b/docs/reference/p2p-network-data-messages.md @@ -19,32 +19,34 @@ Many of the data messages use [inventories](../resources/glossary.md#inventory) The currently-available type identifiers are: -| Type Identifier | Name | Description -|-----------------|-------------------------------------------------------------------------------|--------------- -| 1 | MSG_TX | The hash is a TXID. -| 2 | MSG_BLOCK | The hash is of a block header. -| 3 | MSG_FILTERED_BLOCK | The hash is of a block header; identical to `MSG_BLOCK`. When used in a [`getdata` message](../reference/p2p-network-data-messages.md#getdata), this indicates the response should be a [`merkleblock` message](../reference/p2p-network-data-messages.md#merkleblock) rather than a [`block` message](../reference/p2p-network-data-messages.md#block) (but this only works if a bloom filter was previously configured). **Only for use in [`getdata` messages](../reference/p2p-network-data-messages.md#getdata).** -| 6 | MSG_SPORK | The hash is Spork ID. -| 16 | MSG_DSTX | The hash is CoinJoin Broadcast TX. -| 17 | MSG_GOVERNANCE_OBJECT | The hash is a Governance Object. -| 18 | MSG_GOVERNANCE_OBJECT_VOTE | The hash is a Governance Object Vote. -| 20 | MSG_CMPCT_BLOCK | The hash is of a block header; identical to `MSG_BLOCK`. When used in a [`getdata` message](../reference/p2p-network-data-messages.md#getdata), this indicates the response should be a [`cmpctblock` message](../reference/p2p-network-data-messages.md#cmpctblock). **Only for use in [`getdata` messages](../reference/p2p-network-data-messages.md#getdata).** -| 21 | MSG_QUORUM_FINAL_COMMITMENT | The hash is a long-living masternode quorum final commitment.
_Added in 0.13.0_ -| 23 | MSG_QUORUM_CONTRIB | The hash is a long-living masternode quorum contribution.
_Added in 0.14.0_ -| 24 | MSG_QUORUM_COMPLAINT | The hash is a long-living masternode quorum complaint.
_Added in 0.14.0_ -| 25 | MSG_QUORUM_JUSTIFICATION | The hash is a long-living masternode quorum justification.
_Added in 0.14.0_ -| 26 | MSG_QUORUM_PREMATURE_COMMITMENT | The hash is a long-living masternode quorum premature commitment.
_Added in 0.14.0_ -| 28 | MSG_QUORUM_RECOVERED_SIG | The hash is a long-living masternode quorum recovered signature.

**Note**: Only relayed to other masternodes in the same quorum and nodes that have sent a [`qwatch` message](../reference/p2p-network-quorum-messages.md#qwatch) as of Dash Core 0.17.0
_Added in 0.14.0_ -| 29 | MSG_CLSIG | The hash is a ChainLock signature.
_Added in 0.14.0_ -| 31 | MSG_ISDLOCK | The hash is an LLMQ-based deterministic InstantSend lock ([DIP22](https://github.com/dashpay/dips/blob/master/dip-0022.md)).
_Added in 18.0_ +| Type Identifier | Name | Description +|-----------------|---------------------------------|------------ +| 1 | MSG_TX | The hash is a TXID. +| 2 | MSG_BLOCK | The hash is of a block header. +| 3 | MSG_FILTERED_BLOCK | The hash is of a block header; identical to `MSG_BLOCK`. When used in a [`getdata` message](../reference/p2p-network-data-messages.md#getdata), this indicates the response should be a [`merkleblock` message](../reference/p2p-network-data-messages.md#merkleblock) rather than a [`block` message](../reference/p2p-network-data-messages.md#block) (but this only works if a bloom filter was previously configured). **Only for use in [`getdata` messages](../reference/p2p-network-data-messages.md#getdata).** +| 6 | MSG_SPORK | The hash is Spork ID. +| 16 | MSG_DSTX | The hash is CoinJoin Broadcast TX. +| 17 | MSG_GOVERNANCE_OBJECT | The hash is a Governance Object. +| 18 | MSG_GOVERNANCE_OBJECT_VOTE | The hash is a Governance Object Vote. +| 20 | MSG_CMPCT_BLOCK | The hash is of a block header; identical to `MSG_BLOCK`. When used in a [`getdata` message](../reference/p2p-network-data-messages.md#getdata), this indicates the response should be a [`cmpctblock` message](../reference/p2p-network-data-messages.md#cmpctblock). **Only for use in [`getdata` messages](../reference/p2p-network-data-messages.md#getdata).** +| 21 | MSG_QUORUM_FINAL_COMMITMENT | The hash is a long-living masternode quorum final commitment.
_Added in 0.13.0_ +| 23 | MSG_QUORUM_CONTRIB | The hash is a long-living masternode quorum contribution.
_Added in 0.14.0_ +| 24 | MSG_QUORUM_COMPLAINT | The hash is a long-living masternode quorum complaint.
_Added in 0.14.0_ +| 25 | MSG_QUORUM_JUSTIFICATION | The hash is a long-living masternode quorum justification.
_Added in 0.14.0_ +| 26 | MSG_QUORUM_PREMATURE_COMMITMENT | The hash is a long-living masternode quorum premature commitment.
_Added in 0.14.0_ +| 28 | MSG_QUORUM_RECOVERED_SIG | The hash is a long-living masternode quorum recovered signature.

**Note**: Only relayed to other masternodes in the same quorum and nodes that have sent a [`qwatch` message](../reference/p2p-network-quorum-messages.md#qwatch) as of Dash Core 0.17.0
_Added in 0.14.0_ +| 29 | MSG_CLSIG | The hash is a ChainLock signature.
_Added in 0.14.0_ +| 31 | MSG_ISDLOCK | The hash is an LLMQ-based deterministic InstantSend lock ([DIP22](https://github.com/dashpay/dips/blob/master/dip-0022.md)).
_Added in 18.0_ **Deprecated Type Identifiers** The following type identifiers have been deprecated recently. To see type identifiers removed longer ago, please see the [previous version of documentation](https://docs.dash.org/projects/core/en/19.0.0/docs/reference/p2p-network-data-messages.html). -| Type Identifier | Name | Description -|-----------------|-------------------------------------------------------------------------------|--------------- -| 30 | MSG_ISLOCK | **Deprecated in 20.1.0**
The hash is an LLMQ-based InstantSend lock ([DIP10](https://github.com/dashpay/dips/blob/master/dip-0010.md)).
_Added in 0.14.0_ +| Type Identifier | Name | Description +|-----------------|---------------------------------|------------ +| 4 | MSG_LEGACY_TXLOCK_REQUEST | **Deprecated in 20.0.0**
`MSG_TXLOCK_REQUEST` prior to Dash Core 0.15.0. The hash is an InstantSend transaction lock request. Transactions received this way are automatically converted to a standard [`tx` message](../reference/p2p-network-data-messages.md#tx) as of Dash Core 0.15.0. +| 5 | MSG_TXLOCK_VOTE | **Deprecated in 0.15.0**
The hash is an InstantSend transaction vote. +| 30 | MSG_ISLOCK | **Deprecated in 20.1.0**
The hash is an LLMQ-based InstantSend lock ([DIP10](https://github.com/dashpay/dips/blob/master/dip-0010.md)).
_Added in 0.14.0_ Type identifier zero and type identifiers greater than those shown in the table above are reserved for future implementations. Dash Core ignores all inventories with one of these unknown types.