From 075fb7aa8b44ebacbdeedd45d95ffc5ba3dbd778 Mon Sep 17 00:00:00 2001 From: pauldelucia Date: Thu, 5 Dec 2024 18:51:32 +0700 Subject: [PATCH 1/4] fix: using incorrect proof result in transfers --- packages/rs-sdk/src/platform/transition/transfer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/rs-sdk/src/platform/transition/transfer.rs b/packages/rs-sdk/src/platform/transition/transfer.rs index 6d932c5abbd..55297bee019 100644 --- a/packages/rs-sdk/src/platform/transition/transfer.rs +++ b/packages/rs-sdk/src/platform/transition/transfer.rs @@ -62,8 +62,8 @@ impl TransferToIdentity for Identity { let result = state_transition.broadcast_and_wait(sdk, settings).await?; match result { - StateTransitionProofResult::VerifiedPartialIdentity(identity) => { - identity.balance.ok_or(Error::DapiClientError( + StateTransitionProofResult::VerifiedBalanceTransfer(sender, _recipient) => { + sender.balance.ok_or(Error::DapiClientError( "expected an identity balance after transfer".to_string(), )) } From 444a6013ef17018051b4fc50981233bf809f23ae Mon Sep 17 00:00:00 2001 From: pauldelucia Date: Fri, 6 Dec 2024 11:30:54 +0700 Subject: [PATCH 2/4] fix --- packages/rs-sdk/src/platform/transition/transfer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rs-sdk/src/platform/transition/transfer.rs b/packages/rs-sdk/src/platform/transition/transfer.rs index 7afd0cb31eb..da97c5e026e 100644 --- a/packages/rs-sdk/src/platform/transition/transfer.rs +++ b/packages/rs-sdk/src/platform/transition/transfer.rs @@ -60,7 +60,7 @@ impl TransferToIdentity for Identity { None, )?; - let identity: PartialIdentity = state_transition.broadcast_and_wait(sdk, settings).await?; + let result = state_transition.broadcast_and_wait(sdk, settings).await?; match result { StateTransitionProofResult::VerifiedBalanceTransfer(sender, _recipient) => { From ed67ea76718f1e93e0703effb01eedbebd3e361b Mon Sep 17 00:00:00 2001 From: pauldelucia Date: Fri, 6 Dec 2024 11:34:40 +0700 Subject: [PATCH 3/4] fix --- packages/rs-sdk/src/platform/transition/transfer.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/rs-sdk/src/platform/transition/transfer.rs b/packages/rs-sdk/src/platform/transition/transfer.rs index da97c5e026e..205e2084d6f 100644 --- a/packages/rs-sdk/src/platform/transition/transfer.rs +++ b/packages/rs-sdk/src/platform/transition/transfer.rs @@ -1,5 +1,6 @@ use dpp::identifier::Identifier; use dpp::identity::accessors::IdentityGettersV0; +use dpp::state_transition::proof_result::StateTransitionProofResult; use crate::platform::transition::broadcast::BroadcastStateTransition; use crate::platform::transition::put_settings::PutSettings; From 6f6eaecac008e92ba8f8174d7c883af327198908 Mon Sep 17 00:00:00 2001 From: pauldelucia Date: Fri, 6 Dec 2024 11:40:20 +0700 Subject: [PATCH 4/4] remove unneeded import --- packages/rs-sdk/src/platform/transition/transfer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rs-sdk/src/platform/transition/transfer.rs b/packages/rs-sdk/src/platform/transition/transfer.rs index 205e2084d6f..50aa3e6cb41 100644 --- a/packages/rs-sdk/src/platform/transition/transfer.rs +++ b/packages/rs-sdk/src/platform/transition/transfer.rs @@ -6,7 +6,7 @@ use crate::platform::transition::broadcast::BroadcastStateTransition; use crate::platform::transition::put_settings::PutSettings; use crate::{Error, Sdk}; use dpp::identity::signer::Signer; -use dpp::identity::{Identity, IdentityPublicKey, PartialIdentity}; +use dpp::identity::{Identity, IdentityPublicKey}; use dpp::state_transition::identity_credit_transfer_transition::methods::IdentityCreditTransferTransitionMethodsV0; use dpp::state_transition::identity_credit_transfer_transition::IdentityCreditTransferTransition;