From 377ed8a6c882aca0eac0d91e2254e98dd95434b7 Mon Sep 17 00:00:00 2001 From: PastaClaw Date: Fri, 6 Mar 2026 12:07:49 -0600 Subject: [PATCH 1/2] docs(wasm-dpp): document no-op user fee increase methods on vote transition Addresses CodeRabbit nitpick on dashpay/platform#3183: adds doc comments to the getter and setter for user_fee_increase on MasternodeVoteTransition explaining that these methods are intentional no-ops kept for API compatibility. --- .../voting/state_transition/masternode_vote_transition/mod.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs b/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs index 48a9c98055c..03726e24fe7 100644 --- a/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs +++ b/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs @@ -223,11 +223,14 @@ impl MasternodeVoteTransitionWasm { self.0.is_voting_state_transition() } + /// Masternode vote transitions do not support user fee increase; always returns 0. #[wasm_bindgen(js_name=getUserFeeIncrease)] pub fn get_user_fee_increase(&self) -> u16 { 0 } + /// Masternode vote transitions do not support user fee increase. + /// This method is kept for API compatibility and intentionally does nothing. #[wasm_bindgen(js_name=setUserFeeIncrease)] pub fn set_user_fee_increase(&mut self, _user_fee_increase: u16) {} From 0fc35b2c62d3016e6eaf23df8dc18cd99813469f Mon Sep 17 00:00:00 2001 From: PastaClaw Date: Tue, 10 Mar 2026 17:12:42 -0500 Subject: [PATCH 2/2] docs(wasm-dpp): add API compatibility note to getter doc comment Address CodeRabbit nitpick: mention API compatibility in get_user_fee_increase doc comment for consistency with the setter. --- .../voting/state_transition/masternode_vote_transition/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs b/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs index 03726e24fe7..6e171a6bdd4 100644 --- a/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs +++ b/packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs @@ -224,6 +224,7 @@ impl MasternodeVoteTransitionWasm { } /// Masternode vote transitions do not support user fee increase; always returns 0. + /// This method is kept for API compatibility. #[wasm_bindgen(js_name=getUserFeeIncrease)] pub fn get_user_fee_increase(&self) -> u16 { 0