Skip to content

Commit ba0592f

Browse files
sincejuneBogdan Drutu
authored andcommitted
hook up start and shutdown functions in fileexporter (open-telemetry#3260)
* hook up start and shutdown functions in fileexporter * fix tests * Revert "fix tests" This reverts commit f296b10. * check file closed * Revert changes in exporter.go * Update factory.go Co-authored-by: Bogdan Drutu <lazy@splunk.com>
1 parent 273b63e commit ba0592f

File tree

1 file changed

+21
-3
lines changed

1 file changed

+21
-3
lines changed

exporter/fileexporter/factory.go

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,13 @@ func createTracesExporter(
5252
fe := exporters.GetOrAdd(cfg, func() component.Component {
5353
return &fileExporter{path: cfg.(*Config).Path}
5454
})
55-
return exporterhelper.NewTracesExporter(cfg, params.Logger, fe.Unwrap().(*fileExporter).ConsumeTraces)
55+
return exporterhelper.NewTracesExporter(
56+
cfg,
57+
params.Logger,
58+
fe.Unwrap().(*fileExporter).ConsumeTraces,
59+
exporterhelper.WithStart(fe.Start),
60+
exporterhelper.WithShutdown(fe.Shutdown),
61+
)
5662
}
5763

5864
func createMetricsExporter(
@@ -63,7 +69,13 @@ func createMetricsExporter(
6369
fe := exporters.GetOrAdd(cfg, func() component.Component {
6470
return &fileExporter{path: cfg.(*Config).Path}
6571
})
66-
return exporterhelper.NewMetricsExporter(cfg, params.Logger, fe.Unwrap().(*fileExporter).ConsumeMetrics)
72+
return exporterhelper.NewMetricsExporter(
73+
cfg,
74+
params.Logger,
75+
fe.Unwrap().(*fileExporter).ConsumeMetrics,
76+
exporterhelper.WithStart(fe.Start),
77+
exporterhelper.WithShutdown(fe.Shutdown),
78+
)
6779
}
6880

6981
func createLogsExporter(
@@ -74,7 +86,13 @@ func createLogsExporter(
7486
fe := exporters.GetOrAdd(cfg, func() component.Component {
7587
return &fileExporter{path: cfg.(*Config).Path}
7688
})
77-
return exporterhelper.NewLogsExporter(cfg, params.Logger, fe.Unwrap().(*fileExporter).ConsumeLogs)
89+
return exporterhelper.NewLogsExporter(
90+
cfg,
91+
params.Logger,
92+
fe.Unwrap().(*fileExporter).ConsumeLogs,
93+
exporterhelper.WithStart(fe.Start),
94+
exporterhelper.WithShutdown(fe.Shutdown),
95+
)
7896
}
7997

8098
// This is the map of already created File exporters for particular configurations.

0 commit comments

Comments
 (0)