From d57e165f9a2f2f12ff00171c605fe7708a7b35e2 Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Thu, 22 Jun 2023 16:27:47 +0200 Subject: [PATCH] Use direct download for workspace filer read --- libs/filer/workspace_files_client.go | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/libs/filer/workspace_files_client.go b/libs/filer/workspace_files_client.go index 2b5e718beb..12a536bf5a 100644 --- a/libs/filer/workspace_files_client.go +++ b/libs/filer/workspace_files_client.go @@ -3,7 +3,6 @@ package filer import ( "bytes" "context" - "encoding/base64" "errors" "fmt" "io" @@ -187,18 +186,7 @@ func (w *WorkspaceFilesClient) Read(ctx context.Context, name string) (io.ReadCl // Export file contents. Note the /workspace/export API has a limit of 10MBs // for the file size - // TODO: use direct download once it's fixed. see: https://github.com/databricks/cli/issues/452 - res, err := w.workspaceClient.Workspace.Export(ctx, workspace.ExportRequest{ - Path: absPath, - }) - if err != nil { - return nil, err - } - b, err := base64.StdEncoding.DecodeString(res.Content) - if err != nil { - return nil, err - } - return io.NopCloser(bytes.NewReader(b)), nil + return w.workspaceClient.Workspace.Download(ctx, absPath) } func (w *WorkspaceFilesClient) Delete(ctx context.Context, name string, mode ...DeleteMode) error {