Skip to content

Commit 7c0ca1b

Browse files
ai: apply changes for #870 (1 review thread)
Addresses: - #3600405525 at .github/workflows/engineer-bot-followup.yml:104 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent 2a474fd commit 7c0ca1b

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/engineer-bot-followup.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,15 @@ jobs:
9999
uses: ./.github/actions/setup-poetry
100100
with:
101101
python-version: '3.11'
102-
# Match code-coverage.yml's e2e job: install optional extras (notably
103-
# pyarrow, declared optional=true behind the `pyarrow` extra) so the
104-
# agent's REQUIRED live E2E repro test runs against the same runtime as
105-
# the e2e suite it mirrors. Without this, arrow-touching e2e tests
106-
# ModuleNotFoundError/skip instead of failing red-for-the-right-reason.
102+
# Match code-coverage.yml's --all-extras install so the agent's mocked
103+
# `tests/unit` self-verify runs against the same runtime as CI. The key
104+
# extra here is the REAL `databricks-sql-kernel` wheel: with it present,
105+
# broader unit selections must pass `-m "not realkernel"` (see the
106+
# followup prompt, .bot/prompts/engineer-followup/system.md), otherwise
107+
# the realkernel routing test fails loudly on the sys.modules fake that
108+
# shadows the wheel. (Unlike engineer-bot.yml, this job runs NO e2e test
109+
# — it wires no live-warehouse env, per the NOTE below — so the e2e
110+
# repro is NOT the reason extras are installed here.)
107111
install-args: "--all-extras"
108112

109113
# setup-poetry runs `poetry lock` (to reconcile the lock with the internal

0 commit comments

Comments
 (0)