From 5400d7536f31f52382541fbd1a374b448dc2b531 Mon Sep 17 00:00:00 2001 From: Nicholas Blumhardt Date: Thu, 8 Feb 2018 19:50:32 +1000 Subject: [PATCH] Since query ranges can now be specified using @Timestamp constraints, the angeStartUtc argument to QueryAsync() and QueryCsvAsync() should be optional. Breaking change. --- src/Seq.Api/ResourceGroups/DataResourceGroup.cs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/Seq.Api/ResourceGroups/DataResourceGroup.cs b/src/Seq.Api/ResourceGroups/DataResourceGroup.cs index 08ab59a..d8034f4 100644 --- a/src/Seq.Api/ResourceGroups/DataResourceGroup.cs +++ b/src/Seq.Api/ResourceGroups/DataResourceGroup.cs @@ -26,7 +26,7 @@ internal DataResourceGroup(ISeqConnection connection) /// A structured result set. public async Task QueryAsync( string query, - DateTime rangeStartUtc, + DateTime? rangeStartUtc = null, DateTime? rangeEndUtc = null, SignalExpressionPart signal = null, SignalEntity unsavedSignal = null, @@ -49,7 +49,7 @@ public async Task QueryAsync( /// A CSV result set. public async Task QueryCsvAsync( string query, - DateTime rangeStartUtc, + DateTime? rangeStartUtc = null, DateTime? rangeEndUtc = null, SignalExpressionPart signal = null, SignalEntity unsavedSignal = null, @@ -62,7 +62,7 @@ public async Task QueryCsvAsync( static void MakeParameters( string query, - DateTime rangeStartUtc, + DateTime? rangeStartUtc, DateTime? rangeEndUtc, SignalExpressionPart signal, SignalEntity unsavedSignal, @@ -72,10 +72,13 @@ static void MakeParameters( { parameters = new Dictionary { - {"q", query}, - {nameof(rangeStartUtc), rangeStartUtc} + {"q", query} }; + if (rangeStartUtc != null) + { + parameters.Add(nameof(rangeStartUtc), rangeStartUtc); + } if (rangeEndUtc != null) { parameters.Add(nameof(rangeEndUtc), rangeEndUtc.Value);