Skip to content

Commit 39da8c3

Browse files
bernhardmgruberdavebayer
authored andcommitted
Use cuda::std::array in histogram APIs (NVIDIA#3973)
1 parent cff7dd3 commit 39da8c3

File tree

7 files changed

+404
-214
lines changed

7 files changed

+404
-214
lines changed

cub/benchmarks/bench/histogram/even.cu

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,6 @@ static void even(nvbench::state& state, nvbench::type_list<SampleT, CounterT, Of
7979
SampleT* d_input = thrust::raw_pointer_cast(input.data());
8080
CounterT* d_histogram = thrust::raw_pointer_cast(hist.data());
8181

82-
CounterT* d_histogram1[1] = {d_histogram};
83-
int num_levels1[1] = {num_levels};
84-
SampleT lower_level1[1] = {lower_level};
85-
SampleT upper_level1[1] = {upper_level};
86-
8782
std::uint8_t* d_temp_storage = nullptr;
8883
std::size_t temp_storage_bytes{};
8984

@@ -100,10 +95,10 @@ static void even(nvbench::state& state, nvbench::type_list<SampleT, CounterT, Of
10095
d_temp_storage,
10196
temp_storage_bytes,
10297
d_input,
103-
d_histogram1,
104-
num_levels1,
105-
lower_level1,
106-
upper_level1,
98+
{d_histogram},
99+
{num_levels},
100+
{lower_level},
101+
{upper_level},
107102
num_row_pixels,
108103
num_rows,
109104
row_stride_samples,
@@ -118,10 +113,10 @@ static void even(nvbench::state& state, nvbench::type_list<SampleT, CounterT, Of
118113
d_temp_storage,
119114
temp_storage_bytes,
120115
d_input,
121-
d_histogram1,
122-
num_levels1,
123-
lower_level1,
124-
upper_level1,
116+
{d_histogram},
117+
{num_levels},
118+
{lower_level},
119+
{upper_level},
125120
num_row_pixels,
126121
num_rows,
127122
row_stride_samples,

cub/benchmarks/bench/histogram/multi/even.cu

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,6 @@ static void even(nvbench::state& state, nvbench::type_list<SampleT, CounterT, Of
8989
CounterT* d_histogram_g = thrust::raw_pointer_cast(hist_g.data());
9090
CounterT* d_histogram_b = thrust::raw_pointer_cast(hist_b.data());
9191

92-
CounterT* d_histogram[num_active_channels] = {d_histogram_r, d_histogram_g, d_histogram_b};
93-
int num_levels[num_active_channels] = {num_levels_r, num_levels_g, num_levels_b};
94-
SampleT lower_level[num_active_channels] = {lower_level_r, lower_level_g, lower_level_b};
95-
SampleT upper_level[num_active_channels] = {upper_level_r, upper_level_g, upper_level_b};
96-
9792
std::uint8_t* d_temp_storage = nullptr;
9893
std::size_t temp_storage_bytes{};
9994

@@ -110,10 +105,10 @@ static void even(nvbench::state& state, nvbench::type_list<SampleT, CounterT, Of
110105
d_temp_storage,
111106
temp_storage_bytes,
112107
d_input,
113-
d_histogram,
114-
num_levels,
115-
lower_level,
116-
upper_level,
108+
{d_histogram_r, d_histogram_g, d_histogram_b},
109+
{num_levels_r, num_levels_g, num_levels_b},
110+
{lower_level_r, lower_level_g, lower_level_b},
111+
{upper_level_r, upper_level_g, upper_level_b},
117112
num_row_pixels,
118113
num_rows,
119114
row_stride_samples,
@@ -128,10 +123,10 @@ static void even(nvbench::state& state, nvbench::type_list<SampleT, CounterT, Of
128123
d_temp_storage,
129124
temp_storage_bytes,
130125
d_input,
131-
d_histogram,
132-
num_levels,
133-
lower_level,
134-
upper_level,
126+
{d_histogram_r, d_histogram_g, d_histogram_b},
127+
{num_levels_r, num_levels_g, num_levels_b},
128+
{lower_level_r, lower_level_g, lower_level_b},
129+
{upper_level_r, upper_level_g, upper_level_b},
135130
num_row_pixels,
136131
num_rows,
137132
row_stride_samples,

cub/benchmarks/bench/histogram/multi/range.cu

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,6 @@ static void range(nvbench::state& state, nvbench::type_list<SampleT, CounterT, O
9999
CounterT* d_histogram_g = thrust::raw_pointer_cast(hist_g.data());
100100
CounterT* d_histogram_b = thrust::raw_pointer_cast(hist_b.data());
101101

102-
CounterT* d_histogram[num_active_channels] = {d_histogram_r, d_histogram_g, d_histogram_b};
103-
int num_levels[num_active_channels] = {num_levels_r, num_levels_g, num_levels_b};
104-
SampleT* d_levels[num_active_channels] = {d_levels_r, d_levels_g, d_levels_b};
105-
106102
std::uint8_t* d_temp_storage = nullptr;
107103
std::size_t temp_storage_bytes{};
108104

@@ -119,9 +115,9 @@ static void range(nvbench::state& state, nvbench::type_list<SampleT, CounterT, O
119115
d_temp_storage,
120116
temp_storage_bytes,
121117
d_input,
122-
d_histogram,
123-
num_levels,
124-
d_levels,
118+
{d_histogram_r, d_histogram_g, d_histogram_b},
119+
{num_levels_r, num_levels_g, num_levels_b},
120+
{d_levels_r, d_levels_g, d_levels_b},
125121
num_row_pixels,
126122
num_rows,
127123
row_stride_samples,
@@ -136,9 +132,9 @@ static void range(nvbench::state& state, nvbench::type_list<SampleT, CounterT, O
136132
d_temp_storage,
137133
temp_storage_bytes,
138134
d_input,
139-
d_histogram,
140-
num_levels,
141-
d_levels,
135+
{d_histogram_r, d_histogram_g, d_histogram_b},
136+
{num_levels_r, num_levels_g, num_levels_b},
137+
{d_levels_r, d_levels_g, d_levels_b},
142138
num_row_pixels,
143139
num_rows,
144140
row_stride_samples,

cub/benchmarks/bench/histogram/range.cu

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,6 @@ static void range(nvbench::state& state, nvbench::type_list<SampleT, CounterT, O
8888
SampleT* d_input = thrust::raw_pointer_cast(input.data());
8989
CounterT* d_histogram = thrust::raw_pointer_cast(hist.data());
9090

91-
CounterT* d_histogram1[1] = {d_histogram};
92-
int num_levels1[1] = {num_levels};
93-
SampleT* d_levels1[1] = {d_levels};
94-
9591
std::uint8_t* d_temp_storage = nullptr;
9692
std::size_t temp_storage_bytes{};
9793

@@ -108,9 +104,9 @@ static void range(nvbench::state& state, nvbench::type_list<SampleT, CounterT, O
108104
d_temp_storage,
109105
temp_storage_bytes,
110106
d_input,
111-
d_histogram1,
112-
num_levels1,
113-
d_levels1,
107+
{d_histogram},
108+
{num_levels},
109+
{d_levels},
114110
num_row_pixels,
115111
num_rows,
116112
row_stride_samples,
@@ -125,9 +121,9 @@ static void range(nvbench::state& state, nvbench::type_list<SampleT, CounterT, O
125121
d_temp_storage,
126122
temp_storage_bytes,
127123
d_input,
128-
d_histogram1,
129-
num_levels1,
130-
d_levels1,
124+
{d_histogram},
125+
{num_levels},
126+
{d_levels},
131127
num_row_pixels,
132128
num_rows,
133129
row_stride_samples,

0 commit comments

Comments
 (0)