Merge pull request kubernetes#12482 from tmrts/refactor/iota

Refactor probe.Result enumeration

Author: a-robinson

pkg/apiserver/validator_test.go

@@ -89,7 +89,7 @@ func TestValidate(t *testing.T) {
 			t.Errorf("expected empty string, got %s", status)
 		}
 		if status != test.expectedStatus {
-			t.Errorf("expected %s, got %s", test.expectedStatus.String(), status.String())
+			t.Errorf("expected %s, got %s", test.expectedStatus, status)
 		}
 	}
 }

pkg/probe/probe.go

@@ -16,22 +16,10 @@ limitations under the License.
 
 package probe
 
-type Result int
+type Result string
 
-// Status values must be one of these constants.
 const (
-	Success Result = iota
-	Failure
-	Unknown
+	Success Result = "success"
+	Failure Result = "failure"
+	Unknown Result = "unknown"
 )
-
-func (s Result) String() string {
-	switch s {
-	case Success:
-		return "success"
-	case Failure:
-		return "failure"
-	default:
-		return "unknown"
-	}
-}