Skip to content

Fixed -O0 switch on Mac OS X #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddopson merged 1 commit into from
Jun 12, 2014
Merged

Fixed -O0 switch on Mac OS X #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"src/segfault-handler.cpp"
],
"defines": [ "DEBUG", "_DEBUG" ],
# DDOPSON-2013-04-16 - Some versions of node-gyp don't seem to respect "cflags" (eg, my v0.8.2)
# I hacked the module src to thart the over-optimization issue that previously required -O0, so we work even w/o the flag
# However, the -O0 flag is still preferable for this module where debuggability matters and code size / perf are non-issues
"cflags": [ "-O0" ],
"xcode_settings": {
"OTHER_CFLAGS": [ "-O0" ]
}
}
]
}
Expand Down