diff --git a/source/install/build_tf.py b/source/install/build_tf.py index e2b65eebf6..0bad7f8886 100755 --- a/source/install/build_tf.py +++ b/source/install/build_tf.py @@ -135,7 +135,26 @@ def post_process(self): self.path.chmod(self.path.stat().st_mode | stat.S_IEXEC) if self.gzip is not None: with tarfile.open(self.path) as tar: - tar.extractall(path=self.gzip_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=self.gzip_path) def download(self): """Download the target file."""