From 3c656d4b1941ced0f71606420278823ce7359bc8 Mon Sep 17 00:00:00 2001 From: Jinzhe Zeng Date: Sat, 17 Aug 2024 17:12:37 -0700 Subject: [PATCH 1/3] ci: test Python 3.12 Signed-off-by: Jinzhe Zeng --- .github/workflows/test_python.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml index 3cf56ecbd3..d4f8897d6f 100644 --- a/.github/workflows/test_python.yml +++ b/.github/workflows/test_python.yml @@ -16,7 +16,7 @@ jobs: fail-fast: false matrix: group: [1, 2, 3, 4, 5, 6] - python: ["3.8", "3.11"] + python: ["3.8", "3.12"] steps: - uses: actions/checkout@v4 @@ -68,7 +68,7 @@ jobs: strategy: fail-fast: false matrix: - python: ["3.8", "3.11"] + python: ["3.8", "3.12"] needs: testpython steps: - name: Get durations from cache From a188a1051718698035c54bf16f144511c8bf5b06 Mon Sep 17 00:00:00 2001 From: Jinzhe Zeng Date: Mon, 19 Aug 2024 12:23:45 -0700 Subject: [PATCH 2/3] debug errors --- source/tests/tf/test_parallel_training.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/tests/tf/test_parallel_training.py b/source/tests/tf/test_parallel_training.py index 13346a2c30..18c916e6d8 100644 --- a/source/tests/tf/test_parallel_training.py +++ b/source/tests/tf/test_parallel_training.py @@ -40,12 +40,14 @@ def test_two_workers(self): stdout=sp.PIPE, stderr=sp.STDOUT, ) + lines = [] for line in iter(popen.stdout.readline, b""): if hasattr(line, "decode"): line = line.decode("utf-8") line = line.rstrip() + lines.append(line) popen.wait() - self.assertEqual(0, popen.returncode, "Parallel training failed!") + self.assertEqual(0, popen.returncode, f"Parallel training failed!\n{''.join(lines)}") if __name__ == "__main__": From b23a9aab9cf36353d5536fa8250397cb062dd48c Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 19 Aug 2024 19:24:27 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- source/tests/tf/test_parallel_training.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/tests/tf/test_parallel_training.py b/source/tests/tf/test_parallel_training.py index 18c916e6d8..0d9d7c1b94 100644 --- a/source/tests/tf/test_parallel_training.py +++ b/source/tests/tf/test_parallel_training.py @@ -47,7 +47,9 @@ def test_two_workers(self): line = line.rstrip() lines.append(line) popen.wait() - self.assertEqual(0, popen.returncode, f"Parallel training failed!\n{''.join(lines)}") + self.assertEqual( + 0, popen.returncode, f"Parallel training failed!\n{''.join(lines)}" + ) if __name__ == "__main__":