Skip to content

Commit db27619

Browse files
committed
remove direct github.com/pkg/errors dependency
1 parent 4520973 commit db27619

9 files changed

Lines changed: 29 additions & 27 deletions

File tree

cmd/nebula/cmd_resolve.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ package main
33
import (
44
"context"
55
"database/sql"
6+
"errors"
7+
"fmt"
68

79
ma "github.com/multiformats/go-multiaddr"
810
manet "github.com/multiformats/go-multiaddr/net"
9-
"github.com/pkg/errors"
1011
log "github.com/sirupsen/logrus"
1112
"github.com/urfave/cli/v2"
1213
"github.com/volatiletech/null/v8"
@@ -84,7 +85,7 @@ func ResolveAction(c *cli.Context) error {
8485
if errors.Is(err, context.Canceled) {
8586
return nil
8687
} else if err != nil {
87-
return errors.Wrap(err, "fetching multi addresses")
88+
return fmt.Errorf("fetching multi addresses: %w", err)
8889
}
8990
log.Infof("Fetched %d multi addresses", len(dbmaddrs))
9091
if len(dbmaddrs) == 0 {
@@ -114,7 +115,7 @@ func resolveAddr(ctx context.Context, dbh *sql.DB, mmc *maxmind.Client, uclient
114115
logEntry := log.WithField("maddr", dbmaddr.Maddr)
115116
txn, err := dbh.BeginTx(ctx, nil)
116117
if err != nil {
117-
return errors.Wrap(err, "begin txn")
118+
return fmt.Errorf("begin txn: %w", err)
118119
}
119120
defer db.Rollback(txn)
120121

@@ -124,7 +125,7 @@ func resolveAddr(ctx context.Context, dbh *sql.DB, mmc *maxmind.Client, uclient
124125
if _, err = dbmaddr.Delete(ctx, txn); err != nil {
125126
logEntry.WithError(err).Warnln("Error deleting multi address")
126127
}
127-
return errors.Wrap(err, "parse multi address")
128+
return fmt.Errorf("parse multi address: %w", err)
128129
}
129130

130131
dbmaddr.Resolved = true
@@ -184,13 +185,13 @@ func resolveAddr(ctx context.Context, dbh *sql.DB, mmc *maxmind.Client, uclient
184185
}
185186
if err := dbmaddr.AddIPAddresses(ctx, txn, true, ipaddr); err != nil {
186187
logEntry.WithError(err).WithField("addr", ipaddr.Address).Warnln("Could not insert ip address")
187-
return errors.Wrap(err, "add ip addresses")
188+
return fmt.Errorf("add ip addresses: %w", err)
188189
}
189190
}
190191
}
191192
if _, err = dbmaddr.Update(ctx, txn, boil.Infer()); err != nil {
192193
logEntry.WithError(err).Warnln("Could not update multi address")
193-
return errors.Wrap(err, "update multi address")
194+
return fmt.Errorf("update multi address: %w", err)
194195
}
195196

196197
return txn.Commit()

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ require (
1515
github.com/multiformats/go-multiaddr v0.9.0
1616
github.com/multiformats/go-multiaddr-dns v0.3.1
1717
github.com/oschwald/geoip2-golang v1.8.0
18-
github.com/pkg/errors v0.9.1
1918
github.com/prometheus/client_golang v1.15.0
2019
github.com/sirupsen/logrus v1.9.0
2120
github.com/stretchr/testify v1.8.2
@@ -104,6 +103,7 @@ require (
104103
github.com/opentracing/opentracing-go v1.2.0 // indirect
105104
github.com/oschwald/maxminddb-golang v1.10.0 // indirect
106105
github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58 // indirect
106+
github.com/pkg/errors v0.9.1 // indirect
107107
github.com/pmezard/go-difflib v1.0.0 // indirect
108108
github.com/polydawn/refmt v0.89.0 // indirect
109109
github.com/prometheus/client_model v0.3.0 // indirect

pkg/crawl/crawl_api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ package crawl
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67

78
"github.com/libp2p/go-libp2p/core/peer"
89
manet "github.com/multiformats/go-multiaddr/net"
9-
"github.com/pkg/errors"
1010
log "github.com/sirupsen/logrus"
1111
"golang.org/x/sync/errgroup"
1212

pkg/crawl/db.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ package crawl
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67
"time"
78

89
"github.com/libp2p/go-libp2p/core/peer"
9-
"github.com/pkg/errors"
1010
log "github.com/sirupsen/logrus"
1111
"github.com/volatiletech/null/v8"
1212

pkg/crawl/persister.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ package crawl
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67
"time"
78

8-
"github.com/pkg/errors"
99
log "github.com/sirupsen/logrus"
1010
"go.uber.org/atomic"
1111

pkg/crawl/scheduler.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package crawl
22

33
import (
44
"context"
5+
"fmt"
56
"math"
67
"time"
78

@@ -10,7 +11,6 @@ import (
1011
"github.com/libp2p/go-libp2p/core/network"
1112
"github.com/libp2p/go-libp2p/core/peer"
1213
rcmgr "github.com/libp2p/go-libp2p/p2p/host/resource-manager"
13-
"github.com/pkg/errors"
1414
log "github.com/sirupsen/logrus"
1515

1616
"github.com/dennis-tra/nebula-crawler/pkg/config"
@@ -95,13 +95,13 @@ func NewScheduler(conf *config.Crawl, dbc db.Client) (*Scheduler, error) {
9595
limiter := rcmgr.NewFixedLimiter(rcmgr.InfiniteLimits)
9696
rm, err := rcmgr.NewResourceManager(limiter)
9797
if err != nil {
98-
return nil, errors.Wrap(err, "new resource manager")
98+
return nil, fmt.Errorf("new resource manager: %w", err)
9999
}
100100

101101
// Initialize a single libp2p node that's shared between all crawlers.
102102
h, err := libp2p.New(libp2p.NoListenAddrs, libp2p.ResourceManager(rm), libp2p.UserAgent("nebula-crawler/"+conf.Root.Version()))
103103
if err != nil {
104-
return nil, errors.Wrap(err, "new libp2p host")
104+
return nil, fmt.Errorf("new libp2p host: %w", err)
105105
}
106106

107107
s := &Scheduler{
@@ -219,12 +219,12 @@ func (s *Scheduler) CrawlNetwork(ctx context.Context, bootstrap []peer.AddrInfo)
219219

220220
// Persist the crawl results
221221
if err := s.updateCrawl(context.Background(), crawlerCtx, len(s.inCrawlQueue) == 0); err != nil {
222-
return errors.Wrap(err, "persist crawl")
222+
return fmt.Errorf("persist crawl: %w", err)
223223
}
224224

225225
// Persist associated crawl properties
226226
if err := s.persistCrawlProperties(context.Background()); err != nil {
227-
return errors.Wrap(err, "persist crawl properties")
227+
return fmt.Errorf("persist crawl properties: %w", err)
228228
}
229229

230230
// persist all neighbor information
@@ -265,7 +265,7 @@ func (s *Scheduler) initCrawl(ctx context.Context) error {
265265
log.Infoln("Initializing crawl...")
266266
crawl, err := s.dbc.InitCrawl(ctx)
267267
if err != nil {
268-
return errors.Wrap(err, "creating crawl in db")
268+
return fmt.Errorf("creating crawl in db: %w", err)
269269
}
270270
s.crawl = crawl
271271
s.crawlStart = crawl.StartedAt
@@ -283,7 +283,7 @@ func (s *Scheduler) startCrawlers(ctx context.Context) ([]*Crawler, context.Cont
283283
c, err := NewCrawler(s.host, s.config)
284284
if err != nil {
285285
crawlerCancel()
286-
return nil, nil, nil, errors.Wrap(err, "new crawler")
286+
return nil, nil, nil, fmt.Errorf("new crawler: %w", err)
287287
}
288288
crawlers = append(crawlers, c)
289289
go c.StartCrawling(crawlerCtx, s.crawlQueue, s.crawlResultsQueue)
@@ -306,7 +306,7 @@ func (s *Scheduler) startPersisters(ctx context.Context) ([]*Persister, context.
306306
p, err := NewPersister(s.dbc, s.config, s.crawl)
307307
if err != nil {
308308
persistersCancel()
309-
return nil, nil, errors.Wrap(err, "new persister")
309+
return nil, nil, fmt.Errorf("new persister: %w", err)
310310
}
311311
persisters = append(persisters, p)
312312
go p.StartPersisting(persistersCtx, s.persistQueue, s.persistResultsQueue)

pkg/db/db_client.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"database/sql"
77
"embed"
88
"encoding/hex"
9+
"errors"
910
"fmt"
1011
"io/fs"
1112
"os"
@@ -25,7 +26,6 @@ import (
2526
_ "github.com/lib/pq"
2627
"github.com/libp2p/go-libp2p/core/peer"
2728
ma "github.com/multiformats/go-multiaddr"
28-
"github.com/pkg/errors"
2929
"github.com/prometheus/client_golang/prometheus"
3030
log "github.com/sirupsen/logrus"
3131
"github.com/volatiletech/null/v8"
@@ -337,7 +337,7 @@ func (c *DBClient) GetOrCreateProtocol(ctx context.Context, exec boil.ContextExe
337337
log.WithField("protocol", protocol).Infoln("Upsert protocol")
338338
row := exec.QueryRowContext(ctx, "SELECT upsert_protocol($1)", protocol)
339339
if row.Err() != nil {
340-
return nil, errors.Wrap(row.Err(), "unable to upsert protocol")
340+
return nil, fmt.Errorf("unable to upsert protocol: %w", row.Err())
341341
}
342342

343343
var protocolID *int
@@ -434,7 +434,7 @@ func (c *DBClient) GetOrCreateProtocolsSetID(ctx context.Context, exec boil.Cont
434434
log.WithField("key", hex.EncodeToString([]byte(key))).Infoln("Upsert protocols set")
435435
row := exec.QueryRowContext(ctx, "SELECT upsert_protocol_set_id($1)", types.Int64Array(protocolIDs))
436436
if row.Err() != nil {
437-
return nil, errors.Wrap(row.Err(), "unable to upsert protocols set")
437+
return nil, fmt.Errorf("unable to upsert protocols set: %w", row.Err())
438438
}
439439

440440
var protocolsSetID *int
@@ -465,7 +465,7 @@ func (c *DBClient) GetOrCreateAgentVersionID(ctx context.Context, exec boil.Cont
465465
log.WithField("agentVersion", agentVersion).Infoln("Upsert agent version")
466466
row := exec.QueryRowContext(ctx, "SELECT upsert_agent_version($1)", agentVersion)
467467
if row.Err() != nil {
468-
return nil, errors.Wrap(row.Err(), "unable to upsert agent version")
468+
return nil, fmt.Errorf("unable to upsert agent version: %w", row.Err())
469469
}
470470

471471
var agentVersionID *int

pkg/monitor/dialer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ package monitor
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67
"time"
78

89
"github.com/libp2p/go-libp2p/core/host"
910
"github.com/libp2p/go-libp2p/core/peer"
10-
"github.com/pkg/errors"
1111
log "github.com/sirupsen/logrus"
1212
"go.uber.org/atomic"
1313

pkg/monitor/scheduler.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package monitor
33
import (
44
"context"
55
"database/sql"
6+
"errors"
7+
"fmt"
68
"sync"
79
"time"
810

@@ -12,7 +14,6 @@ import (
1214
"github.com/libp2p/go-libp2p/core/peer"
1315
rcmgr "github.com/libp2p/go-libp2p/p2p/host/resource-manager"
1416
ma "github.com/multiformats/go-multiaddr"
15-
"github.com/pkg/errors"
1617
log "github.com/sirupsen/logrus"
1718
"go.uber.org/atomic"
1819

@@ -60,7 +61,7 @@ func NewScheduler(conf *config.Monitor, dbc *db.DBClient) (*Scheduler, error) {
6061
limiter := rcmgr.NewFixedLimiter(rcmgr.InfiniteLimits)
6162
rm, err := rcmgr.NewResourceManager(limiter)
6263
if err != nil {
63-
return nil, errors.Wrap(err, "new resource manager")
64+
return nil, fmt.Errorf("new resource manager: %w", err)
6465
}
6566

6667
// Initialize a single libp2p node that's shared between all dialers.
@@ -97,7 +98,7 @@ func (s *Scheduler) StartMonitoring(ctx context.Context) error {
9798
for i := 0; i < s.config.MonitorWorkerCount; i++ {
9899
d, err := NewDialer(s.host, s.config)
99100
if err != nil {
100-
return errors.Wrap(err, "new dialer")
101+
return fmt.Errorf("new dialer: %w", err)
101102
}
102103

103104
dialers = append(dialers, d)
@@ -206,7 +207,7 @@ func (s *Scheduler) scheduleDial(ctx context.Context, session *models.SessionsOp
206207
// Parse peer ID from database
207208
peerID, err := peer.Decode(session.R.Peer.MultiHash)
208209
if err != nil {
209-
return errors.Wrap(err, "decode peer ID")
210+
return fmt.Errorf("decode peer ID: %w", err)
210211
}
211212
logEntry := log.WithField("peerID", utils.FmtPeerID(peerID))
212213

0 commit comments

Comments
 (0)