Skip to content

Commit e31fe9a

Browse files
marcysuttonWilcoFiers
authored andcommitted
fix: Allow title on button-name (#794)
Closes #747 Closes #765
1 parent f5afadb commit e31fe9a

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

lib/rules/button-name.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@
2020
"aria-label",
2121
"aria-labelledby",
2222
"role-presentation",
23-
"role-none"
23+
"role-none",
24+
"non-empty-title"
2425
],
2526
"none": [
2627
"focusable-no-name"

test/integration/rules/button-name/button-name.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,5 @@
1010
<div id="labeldiv">Button label</div>
1111
<div id="emptydiv"></div>
1212
<button id="combo" aria-label="Aria Name">Name</button>
13+
<button id="buttonTitle" title="Title"></button>
14+
<input id="inputTitle" title="Search" type="button">

test/integration/rules/button-name/button-name.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"description": "button-name test",
33
"rule": "button-name",
44
"violations": [["#empty"], ["#val"], ["#alempty"], ["#albmissing"], ["#albempty"]],
5-
"passes": [["#text"], ["#al"], ["#alb"], ["#combo"]]
5+
"passes": [["#text"], ["#al"], ["#alb"], ["#combo"], ["#buttonTitle"], ["#inputTitle"]]
66
}

0 commit comments

Comments
 (0)