WIP 20250515-1655

Author: jechol

lib/transformer.ex

@@ -66,21 +66,23 @@ defmodule AshRandomParams.Transformer do
     init_keys = init_params |> Map.keys()
     union_keys = tagged_unions |> Map.values()
 
+    belongs_to_names =
+      resource
+      |> Ash.Resource.Info.relationships()
+      |> Enum.flat_map(fn
+        %BelongsTo{name: name, source_attribute: src_attr} -> [name, src_attr]
+        _ -> []
+      end)
+
     new_attrs =
       Ash.Resource.Info.attributes(resource)
       |> Enum.filter(&(&1.name in action.accept))
+      |> Enum.reject(&(&1.name in belongs_to_names))
       |> Enum.reject(&(&1.name in init_keys))
       |> Enum.reject(&(&1.name in union_keys))
       |> Enum.reject(&(&1.name in exclude))
       |> Enum.reject(&(&1.allow_nil? and &1.name not in include))
 
-    belongs_to_names =
-      resource
-      |> Ash.Resource.Info.relationships()
-      |> Enum.flat_map(fn
-        %BelongsTo{name: name, source_attribute: src_attr} -> [name, src_attr]
-        _ -> []
-      end)
 
     new_args =
       action.arguments

test/ash_random_params_test.exs

@@ -1,7 +1,7 @@
 defmodule AshRandomParamsTest do
   use ExUnit.Case, async: true
 
-  alias __MODULE__.{Random, Post, Domain}
+  alias __MODULE__.{Random, Post, Author, Domain}
 
   defmodule Post do
     use Ash.Resource, domain: Domain, data_layer: Ash.DataLayer.Ets, extensions: [AshRandomParams]
@@ -24,11 +24,35 @@ defmodule AshRandomParamsTest do
       defaults [:read, :destroy, create: :*, update: :*]
     end
 
+    relationships do
+      belongs_to :author, Author, allow_nil?: false, public?: true
+    end
+
     random_params do
       random Random
     end
   end
 
+  defmodule Author do
+    use Ash.Resource, domain: Domain, data_layer: Ash.DataLayer.Ets
+
+    ets do
+      private? true
+    end
+
+    attributes do
+      uuid_primary_key :id
+    end
+
+    relationships do
+      has_many :posts, Post, public?: true
+    end
+
+    actions do
+      defaults [:read, :destroy, create: :*, update: :*]
+    end
+  end
+
   defmodule Random do
     use AshRandomParams.Random
 
@@ -48,80 +72,84 @@ defmodule AshRandomParamsTest do
 
     resources do
       resource Post
+      resource Author
     end
   end
 
-  test "with no options" do
-    assert {:ok, ret} =
-             Post
-             |> Ash.ActionInput.for_action(
-               :random_params,
-               %{
-                 action: :create
-               }
-             )
-             |> Ash.run_action()
-
-    assert ret.req_str |> String.starts_with?("req_str-")
-    assert ret.opt_str == nil
-    assert ret.req_int == 777
-    assert ret.opt_int == nil
-  end
+  describe "options" do
+    test "with no options" do
+      assert {:ok, ret} =
+               Post
+               |> Ash.ActionInput.for_action(
+                 :random_params,
+                 %{
+                   action: :create
+                 }
+               )
+               |> Ash.run_action()
+
+      assert ret.req_str |> String.starts_with?("req_str-")
+      assert ret.opt_str == nil
+      assert ret.req_int == 777
+      assert ret.opt_int == nil
+      assert ret |> Map.has_key?(:author_id)
+    end
 
-  test "with init_params" do
-    assert {:ok, ret} =
-             Post
-             |> Ash.ActionInput.for_action(
-               :random_params,
-               %{
-                 action: :create,
-                 init_params: %{
-                   req_int: 123
+    test "with init_params" do
+      assert {:ok, ret} =
+               Post
+               |> Ash.ActionInput.for_action(
+                 :random_params,
+                 %{
+                   action: :create,
+                   init_params: %{
+                     req_int: 123
+                   }
                  }
-               }
-             )
-             |> Ash.run_action()
+               )
+               |> Ash.run_action()
 
-    assert ret.req_str |> String.starts_with?("req_str-")
-    assert ret.opt_str == nil
-    assert ret.req_int == 123
-    assert ret.opt_int == nil
-  end
+      assert ret.req_str |> String.starts_with?("req_str-")
+      assert ret.opt_str == nil
+      assert ret.req_int == 123
+      assert ret.opt_int == nil
+    end
 
-  test "with include" do
-    assert {:ok, ret} =
-             Post
-             |> Ash.ActionInput.for_action(
-               :random_params,
-               %{
-                 action: :create,
-                 include: [:opt_str]
-               }
-             )
-             |> Ash.run_action()
+    test "with include" do
+      assert {:ok, ret} =
+               Post
+               |> Ash.ActionInput.for_action(
+                 :random_params,
+                 %{
+                   action: :create,
+                   include: [:opt_str]
+                 }
+               )
+               |> Ash.run_action()
 
-    assert ret.req_str |> String.starts_with?("req_str-")
-    assert ret.opt_str |> String.starts_with?("opt_str-")
-    assert ret.req_int == 777
-    assert ret.opt_int == nil
-  end
+      assert ret.req_str |> String.starts_with?("req_str-")
+      assert ret.opt_str |> String.starts_with?("opt_str-")
+      assert ret.req_int == 777
+      assert ret.opt_int == nil
+    end
 
-  test "with exclude" do
-    assert {:ok, ret} =
-             Post
-             |> Ash.ActionInput.for_action(
-               :random_params,
-               %{
-                 action: :create,
-                 exclude: [:req_str]
-               }
-             )
-             |> Ash.run_action()
+    test "with exclude" do
+      assert {:ok, ret} =
+               Post
+               |> Ash.ActionInput.for_action(
+                 :random_params,
+                 %{
+                   action: :create,
+                   exclude: [:req_str]
+                 }
+               )
+               |> Ash.run_action()
 
-    assert ret.req_str == nil
-    assert ret.opt_str == nil
-    assert ret.req_int == 777
-    assert ret.opt_int == nil
+      assert ret.req_str == nil
+      assert ret.opt_str == nil
+      assert ret.req_int == 777
+      assert ret.opt_int == nil
+    end
   end
 
   test "code interface" do