rename params

Author: jechol

README.md

@@ -66,8 +66,8 @@ Post.random_params!(:create, %{key: "value"})
 
 # With options
 Post.random_params!(:create, %{key: "value"}, %{
-  fill: [:optional_field],    # Fill optional fields
-  unfill: [:required_field]   # Leave required fields as nil
+  populate: [:optional_field],    # Fill optional fields
+  omit: [:required_field]   # Leave required fields as nil
 })
 ```
 

lib/transformer.ex

@@ -13,14 +13,14 @@ defmodule AshRandomParams.Transformer do
   def add_random_params(dsl_state) do
     action = Builder.build_action_argument(:action, :atom, default: :create)
     init_params = Builder.build_action_argument(:init_params, :map, default: %{})
-    fill = Builder.build_action_argument(:fill, {:array, :atom}, default: [])
-    unfill = Builder.build_action_argument(:unfill, {:array, :atom}, default: [])
+    populate = Builder.build_action_argument(:populate, {:array, :atom}, default: [])
+    omit = Builder.build_action_argument(:omit, {:array, :atom}, default: [])
     keep_defaults? = Builder.build_action_argument(:keep_defaults?, :boolean, default: true)
 
     dsl_state
     |> Builder.add_action(:action, :random_params,
       returns: :map,
-      arguments: [action, init_params, unfill, fill, keep_defaults?],
+      arguments: [action, init_params, omit, populate, keep_defaults?],
       run: &__MODULE__.do_random_params/2
     )
     |> Builder.add_interface(:random_params, args: [:action, {:optional, :init_params}])
@@ -44,8 +44,8 @@ defmodule AshRandomParams.Transformer do
           arguments: %{
             action: action,
             init_params: init_params,
-            unfill: unfill,
-            fill: fill,
+            omit: omit,
+            populate: populate,
             keep_defaults?: keep_defaults?
           }
         } =
@@ -86,7 +86,7 @@ defmodule AshRandomParams.Transformer do
             |> Enum.reject(&(&1.name in belongs_to_attrs))
           end
         end)
-        |> Enum.reject(&(&1.name in unfill))
+        |> Enum.reject(&(&1.name in omit))
         |> Enum.reject(&(&1.name in init_keys))
         |> Map.new(fn %{name: name, default: default} ->
           value =
@@ -109,16 +109,16 @@ defmodule AshRandomParams.Transformer do
         {random_mod, random_opts} =
           random = AshRandomParams.Info.random_params_random!(input.resource)
 
-        fields_by_unfill =
+        fields_by_omit =
           candidates
           |> Enum.reject(&(&1.name in rel_names))
           |> Enum.reject(&(&1.name in belongs_to_attrs))
-          |> Enum.reject(&(&1.name in unfill))
+          |> Enum.reject(&(&1.name in omit))
           |> Enum.reject(& &1.allow_nil?)
 
-        fields_by_fill = candidates |> Enum.filter(&(&1.name in fill))
+        fields_by_fill = candidates |> Enum.filter(&(&1.name in populate))
 
-        (fields_by_unfill ++ fields_by_fill)
+        (fields_by_omit ++ fields_by_fill)
         |> Enum.reject(&(&1.name in init_keys))
         |> Map.new(fn %{name: name, default: default} = attr_or_arg ->
           value =

test/ash_random_params_test.exs

@@ -119,7 +119,7 @@ defmodule AshRandomParamsTest do
                |> Ash.run_action!()
     end
 
-    test "with fill" do
+    test "with populate" do
       assert %{
                author_id: nil,
                req_str: "req_str-" <> _,
@@ -132,13 +132,13 @@ defmodule AshRandomParamsTest do
                  :random_params,
                  %{
                    action: :create,
-                   fill: [:opt_str]
+                   populate: [:opt_str]
                  }
                )
                |> Ash.run_action!()
     end
 
-    test "with unfill" do
+    test "with omit" do
       assert %{
                author_id: nil,
                opt_str: nil,
@@ -151,7 +151,7 @@ defmodule AshRandomParamsTest do
                  :random_params,
                  %{
                    action: :create,
-                   unfill: [:req_str]
+                   omit: [:req_str]
                  }
                )
                |> Ash.run_action!()
@@ -210,7 +210,7 @@ defmodule AshRandomParamsTest do
              Post.random_params!(
                :create,
                %{opt_int: 456},
-               %{fill: [:opt_int]}
+               %{populate: [:opt_int]}
              )
   end
 end