Skip to content

Commit 1223160

Browse files
committed
fix(hub): relex builtin views ids
1 parent d3bb72f commit 1223160

2 files changed

Lines changed: 5 additions & 18 deletions

File tree

packages/hub/src/node/host-docks.ts

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,8 @@ export class DevframeDocksHost implements DevframeDocksHostType {
139139
}
140140
this.validateGroupMembership(view)
141141
this.prepareRemoteRegistration(view)
142-
const entry = this.withBuiltinCategory(view)
143-
this.views.set(entry.id, entry)
144-
this.events.emit('dock:entry:updated', entry)
142+
this.views.set(view.id, view)
143+
this.events.emit('dock:entry:updated', view)
145144

146145
return {
147146
update: (patch) => {
@@ -159,20 +158,8 @@ export class DevframeDocksHost implements DevframeDocksHostType {
159158
}
160159
this.validateGroupMembership(view)
161160
this.prepareRemoteRegistration(view)
162-
const entry = this.withBuiltinCategory(view)
163-
this.views.set(entry.id, entry)
164-
this.events.emit('dock:entry:updated', entry)
165-
}
166-
167-
/**
168-
* `~builtin` views default their category to `~builtin` so the viewer's
169-
* native views group together and sort last — a high-level integration
170-
* registering one needn't repeat the category.
171-
*/
172-
private withBuiltinCategory<T extends DevframeDockUserEntry>(view: T): T {
173-
if (view.type === '~builtin' && view.category === undefined)
174-
return { ...view, category: '~builtin' }
175-
return view
161+
this.views.set(view.id, view)
162+
this.events.emit('dock:entry:updated', view)
176163
}
177164

178165
private validateGroupMembership(view: DevframeDockUserEntry): void {

packages/hub/src/types/docks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ export interface DevframeViewCustomRender extends DevframeDockEntryBase {
184184
*/
185185
export interface DevframeViewBuiltin extends DevframeDockEntryBase {
186186
type: '~builtin'
187-
id: '~terminals' | '~messages' | '~client-auth-notice' | '~settings' | '~popup'
187+
id: string
188188
}
189189

190190
export interface DevframeViewJsonRender extends DevframeDockEntryBase {

0 commit comments

Comments
 (0)