#28: Change Priotities of implemented Rules#45
Merged
Conversation
hohwille
approved these changes
Mar 30, 2023
Contributor
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@dendmicap Thanks for your PR and thanks for figuring out how to change the prios 👍
Sorry, that it took so long for me to review...
For homogeneous code style you could use static imports in all or no cases, but this is really unimportant so I can already merge your PR.
hohwille
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rules in the old SonarQube plugin had different priorities than other rules. The most used priority was "CRITICAL". The default priority of ArchUnit is "MEDIUM". This way a mapping like this can be implemented:
HIGH=BLOCKER
MEDIUM=CRITICAL
LOW=MAJOR
LayerRules had the most variation of different priorities, but its currently not possible to simply add different priorities to the implementation of the LayerRules in ArchUnit.
#28