Skip to content

WIP: feature/consoleDockerCompose#76

Merged
MarcelDiessner merged 31 commits into
devonfw-tutorials:mainfrom
MarcelDiessner:feature/consoleDockerCompose
Feb 15, 2021
Merged

WIP: feature/consoleDockerCompose#76
MarcelDiessner merged 31 commits into
devonfw-tutorials:mainfrom
MarcelDiessner:feature/consoleDockerCompose

Conversation

@MarcelDiessner
Copy link
Copy Markdown
Collaborator

@MarcelDiessner MarcelDiessner commented Dec 22, 2020

No description provided.

@MarcelDiessner
Copy link
Copy Markdown
Collaborator Author

MarcelDiessner commented Dec 22, 2020

I don't really know what to check in the assertDockerCompose

@MarcelDiessner MarcelDiessner linked an issue Dec 22, 2020 that may be closed by this pull request
console runner: dockerCompose #66
Closed
@MarcelDiessner MarcelDiessner self-assigned this Jan 22, 2021
@MarcelDiessner
Copy link
Copy Markdown
Collaborator Author

MarcelDiessner commented Jan 22, 2021 •
edited
Loading

@maybeec Only the linux pipeline succeeds, but windows always fails, i tried multiple projects. Locally on my windows pc it works fine. Seems like its a problem with the installed docker. See failed jobs for logs. How do i fix this?

@GuentherJulian
Copy link
Copy Markdown
Contributor

GuentherJulian commented Jan 22, 2021

@MarcelDiessner, @maybeec I think for most projects the command will not work.
I can reproduce the error thrown in the build for the my-thai-star project when switching to windows containers in docker. In the project, 'bridge' is set as the network driver for docker. This driver is not supported on windows. When switching back to linux containers, the docker-compose command works as expected.
The problem is that linux containers are not supported on Windows Server 2019, as explained here: actions/runner-images#1143 (comment)

@MarcelDiessner
Copy link
Copy Markdown
Collaborator Author

MarcelDiessner commented Jan 29, 2021

I think with my latest changes i should be able to make it run on windows pipeline, but the path of the DockerCli.exe is wrong. Is there a way to get the path of this file.

@GuentherJulian
Copy link
Copy Markdown
Contributor

GuentherJulian commented Jan 29, 2021

I think with my latest changes i should be able to make it run on windows pipeline, but the path of the DockerCli.exe is wrong. Is there a way to get the path of this file.

Maybe you can extract the docker installation directory from the environment variables.

@MarcelDiessner MarcelDiessner requested review from SchettlerKoehler and removed request for maybeec February 10, 2021 15:14
GuentherJulian
GuentherJulian requested changes Feb 12, 2021
View reviewed changes
Comment thread documentation/Functions.md
Comment thread engine/runner.ts Outdated
Comment thread runners/console/index.ts Outdated
Comment thread runners/console/index.ts Outdated
GuentherJulian
GuentherJulian requested changes Feb 15, 2021
View reviewed changes
Comment thread documentation/Functions.md
@MarcelDiessner
Update Functions.md
c6aeb08 
Added path to docker-compose
@MarcelDiessner MarcelDiessner merged commit f76f7e9 into devonfw-tutorials:main Feb 15, 2021
@MarcelDiessner MarcelDiessner deleted the feature/consoleDockerCompose branch March 23, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuentherJulian GuentherJulian GuentherJulian approved these changes

@SchettlerKoehler SchettlerKoehler Awaiting requested review from SchettlerKoehler

Assignees

@MarcelDiessner MarcelDiessner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

console runner: dockerCompose

2 participants

@MarcelDiessner @GuentherJulian