Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Release with new features and bugfixes:
* https://github.com/devonfw/IDEasy/issues/1685[#1685]: Add Nest CLI to IDEasy commandlets
* https://github.com/devonfw/IDEasy/issues/1882[#1882]: Add AWS CDK to IDEasy commandlets
* https://github.com/devonfw/IDEasy/issues/800[#800]: Fix infinite recursion in Sonar start/stop on macOS
* https://github.com/devonfw/IDEasy/issues/1886[#1886]: Fix NpmBasedCommandlet shows wrong tool version after install
* https://github.com/devonfw/IDEasy/issues/1884[#1884]: Fix java unzipping losing symlink information
* https://github.com/devonfw/IDEasy/issues/1716[#1716]: Add commandlet for Claude Code CLI
* https://github.com/devonfw/IDEasy/issues/1844[#1844]: Fix vscode installation hanging indefinitely in WSL Linux environments
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,17 @@ public VersionIdentifier getInstalledVersion() {
return this.installedVersion.get();
}

/**
* Override to ignore the {@code toolPath} parameter and use the package-manager based detection of the actually installed version.
*
* @param toolPath the installation {@link Path} where to find the version file.
* @return the installed version or null if not installed.
*/
@Override
protected VersionIdentifier getInstalledVersion(Path toolPath) {
return getInstalledVersion();
}

@Override
protected final void performToolInstallation(ToolInstallRequest request, Path installationPath) {

Expand All @@ -190,8 +201,8 @@ protected final void performToolInstallation(ToolInstallRequest request, Path in
}

/**
* @return {@code false} if the underlying {@link #getPackageManagerClass() package manager} should also be installed, {@code false} to skip that additional installation (e.g. to prevent infinite loop in case of cyclic
* dependencies between package manager based tools such as node and npm).
* @return {@code false} if the underlying {@link #getPackageManagerClass() package manager} should also be installed, {@code false} to skip that additional
* installation (e.g. to prevent infinite loop in case of cyclic dependencies between package manager based tools such as node and npm).
*/
protected boolean isSkipInstallation() {
return false;
Expand Down
Loading