Fix for #68: Updated coloring and added visual cues in rule descriptions#69
Merged
hohwille merged 16 commits intoApr 27, 2020
Merged
Conversation
hohwille
reviewed
Apr 24, 2020
Member
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@lmarniazman thanks for improving the colors.
However, I would suggest to use CSS styles for this.
Can't we just include a CSS file that is referenced within our HTML files where we define colors like #785EF0 or #979696 in a central place?
If not possible and each color occurs only once per HTML file, I am happy to approve.
Member
|
As we have discussed it is not as easy using CSS here. So the PR is fine to be merged as it resolves the contrast issue. As a nice-to-have we can later ask in SonarQube forum for help how CSS could be used or try some own solution e.g. via generation by processing the HTML with maven during the build... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #68