Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>compA.service</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>compA.service</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>compB.service</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>compB.service</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>compA.service</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>compA.service</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>compB.logic</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>compB.logic</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>compA.logic</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>compA.logic</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>compB.dataaccess</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>compB.dataaccess</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>compA.dataaccess</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>compA.dataaccess</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>compB.dataaccess</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>compB.dataaccess</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>compA.batch</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>compA.batch</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>compB.logic</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>compB.logic</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@ <h2>Noncompliant Code Examples</h2>
<pre>
package com.devonfw.ide.sonarqube.logic.impl;

<span style='color: red'>import org.springframework.transaction.annotation.Transactional;</span>
<del style='color: #979696'><span style='color: #FFB000'>import org.springframework.transaction.annotation.Transactional;</span></del>

public class MyClass {}
</pre>
<br>
<pre>
package com.devonfw.ide.sonarqube.common.<span style='color: red'>api</span>;
package com.devonfw.ide.sonarqube.common.<del style='color: #979696'><span style='color: #FFB000'>api</span></del>;

<span style='color: red'>import javax.transaction.Transactional;</span>
<del style='color: #979696'><span style='color: #FFB000'>import javax.transaction.Transactional;</span></del>

public class MyClass {}
</pre>
<h2>Compliant Solution</h2>
<pre>
package com.devonfw.ide.sonarqube.logic.<span style='color: green'>impl</span>;
package com.devonfw.ide.sonarqube.logic.<u style='color: #979696'><span style='color: #648FFF'>impl</span></u>;

<span style='color: green'>import javax.transaction.Transactional;</span>
<u style='color: #979696'><span style='color: #648FFF'>import javax.transaction.Transactional;</span></u>

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ <h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.dataaccess.api;

<span style='color: red'>import com.mysema.query.jpa.impl.JPAQuery;</span>
<del stlye='color: #979696'><span style='color: #FFB000'>import com.mysema.query.jpa.impl.JPAQuery;</span></del>

public class MyClass {}
</pre>
<h2>Compliant Solution</h2>
<pre>
package com.devonfw.ide.sonarqube.dataaccess.api;

<span style='color: green'>import com.querydsl.jpa.impl.JPAQuery;</span>
<u style='color: #979696'><span style='color: #648FFF'>import com.querydsl.jpa.impl.JPAQuery;</span></u>

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<p>This rule checks that the JPA is only used in the dataaccess layer and optionally in common for embeddables.</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: red'>service</span>.api;
package com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>service</span></del>.api;

<span style='color: red'>import javax.persistence.EntityManager;</span>
<del style='color: #979696'><span style='color: #FFB000'>import javax.persistence.EntityManager;</span></del>

public class MyClass {}
</pre>
<h2>Compliant Solution</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: green'>dataaccess</span>.api;
package com.devonfw.ide.sonarqube.<u style='color: #979696'></u><span style='color: #648FFF'>dataaccess</span></u>.api;

<span style='color: green'>import javax.persistence.Entity;</span>
<span style='color: green'>import javax.persistence.Table;</span>
<u style='color: #979696'><span style='color: #648FFF'>import javax.persistence.Entity;</span></u>
<u style='color: #979696'><span style='color: #648FFF'>import javax.persistence.Table;</span></u>

@Entity
@Table(name="Foo")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,27 @@
</p>
<h2>Noncompliant Code Examples</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: red'>logic</span>.impl;
package com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>logic</span></del>.impl;

<span style='color: red'>import org.hibernate.Session;</span>
<del style='color: #979696'><span style='color: #FFB000'>import org.hibernate.Session;</span></del>

public class MyClass {}
</pre>
<br>
<pre>
package com.devonfw.ide.sonarqube.dataaccess.api;

<span style='color: red'>import org.hibernate.annotations.OrderBy;</span>
<del style='color: #979696'><span style='color: #FFB000'>import org.hibernate.annotations.OrderBy;</span></del>

public class MyClass {}
</pre>
<h2>Compliant Solution</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: green'>dataaccess.impl</span>;
package com.devonfw.ide.sonarqube.<u style='color: #979696'><span style='color: #648FFF'>dataaccess.impl</span></u>;

<span style='color: green'>import org.hibernate.Session;</span>
<span style='color: green'>import org.hibernate.annotations.FilterDef;</span>
<span style='color: green'>import org.hibernate.envers.Audited;</span>
<u style='color: #979696'><span style='color: #648FFF'>import org.hibernate.Session;</span></u>
<u style='color: #979696'><span style='color: #648FFF'>import org.hibernate.annotations.FilterDef;</span></u>
<u style='color: #979696'><span style='color: #648FFF'>import org.hibernate.envers.Audited;</span></u>

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ <h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.dataaccess.api;

<span style='color: red'>import com.google.common.base.Objects;</span>
<del style='color: #979696'><span style='color: #FFB000'>import com.google.common.base.Objects;</span></del>

public class MyClass {}
</pre>
<h2>Compliant Solution</h2>
<pre>
package com.devonfw.ide.sonarqube.dataaccess.api;

<span style='color: green'>import java.util.Objects;</span>
<u style='color: #979696'><span style='color: #648FFF'>import java.util.Objects;</span></u>

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@ <h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.logic.impl;

<span style='color: red'>import org.hibernate.Type;</span>
<span style='color: red'>import javax.persistence.Convert;</span>
<del style='color: #979696'><span style='color: #FFB000'>import org.hibernate.Type;</span></del>
<del style='color: #979696'><span style='color: #FFB000'>import javax.persistence.Convert;</span></del>

public class MyClass {}
</pre>
<h2>Compliant Solution</h2>
<pre>
package com.devonfw.ide.sonarqube.logic.impl;

<span style='color: green'>import javax.persistence.Converter;</span>
<span style='color: green'>import javax.persistence.AttributeConverter;</span>
<u style='color: #979696'><span style='color: #648FFF'>import javax.persistence.Converter;</span></u>
<u style='color: #979696'><span style='color: #648FFF'>import javax.persistence.AttributeConverter;</span></u>

<span style='color: green'>@Converter</span>
public class CustomConverter <span style='color: green'>implements AttributeConverter</span> {}
<u style='color: #979696'><span style='color: #648FFF'>@Converter</span></u>
public class CustomConverter <u style='color: #979696'><span style='color: #648FFF'>implements AttributeConverter</span></u> {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>dataaccess</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>dataaccess</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>service</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>service</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>batch</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>batch</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>dataaccess</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>dataaccess</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>dataaccess</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>dataaccess</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>logic</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>logic</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<p>This rule checks that common layer does not depend on another layer.</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>common</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>common</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>client</span>.api.Foo;
import com.devonfw.ide.sonarqube.<span style='color: red'>service</span>.api.Bar;
import com.devonfw.ide.sonarqube.<span style='color: red'>logic</span>.api.Some;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>client</span></del>.api.Foo;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>service</span></del>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>logic</span></del>.api.Some;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<p>This rule checks that none of the other layers depend on client layer.</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>service</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>service</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>client</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>client</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>client</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>client</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>logic</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>logic</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>client</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>client</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>dataaccess</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>dataaccess</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>client</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>client</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>batch</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>batch</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>service</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>service</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>batch</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>batch</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>batch</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>batch</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>service</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>service</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>service</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>service</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>dataaccess</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>dataaccess</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
</p>
<h2>Noncompliant Code Example</h2>
<pre>
package com.devonfw.ide.sonarqube.<span style='color: blue'>logic</span>.api;
package com.devonfw.ide.sonarqube.<span style='color: #785EF0'>logic</span>.api;

import com.devonfw.ide.sonarqube.<span style='color: red'>service</span>.api.Bar;
import com.devonfw.ide.sonarqube.<del style='color: #979696'><span style='color: #FFB000'>service</span></del>.api.Bar;

public class MyClass {}
</pre>
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<p>This rule checks that classes inheriting from Cto classes end with the suffix Cto.</p>
<h2>Noncompliant Code Example</h2>
<pre>
public class <span style='color: red'>MyClass</span> extends AbstractCto {}
public class <del style='color: #979696'><span style='color: #FFB000'>MyClass</span></del> extends AbstractCto {}
</pre>
<h2>Compliant Solution</h2>
<pre>
public class <span style='color: green'>ClassCto</span> extends AbstractCto {}
public class <u style='color: #979696'><span style='color: #648FFF'>ClassCto</span></u> extends AbstractCto {}
</pre>
Loading