fix(cli): make down command stop and delete containers per spec#153
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 55 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b6d6f09 to
6c53711
Compare
The official devcontainer CLI's 'down' command both stops and deletes containers. Previously, devsy's 'down' was just an alias for 'stop', which only stopped containers without deleting them. This removes the alias and introduces a standalone 'down' command that stops the workspace first, then deletes it, matching spec behavior.
- Add log message when workspace is not running and stop is skipped - Add DecodeOptionsFromEnv for delete flags matching delete.go pattern - Add comment noting workspace.Delete handles single-machine cleanup
…lOrder Replace the two-phase sort (Kahn topo-sort then post-sort reorder) with a spec-compliant round-based priority algorithm that integrates override priorities directly into the topological sort. Validate that overrideFeatureInstallOrder does not place a feature before any of its dependsOn dependencies, returning an error if violated.
Two tests: - down stops and deletes workspace (container gone, list empty) - stop only stops, does not delete (regression guard)
b98b4df to
16a9a40
Compare
1 participant
Summary
downcommand both stops and deletes containers, but devsy'sdownwas previously just an alias forstop(only stopping without deleting)downalias from thestopcommand and introduces a standalonedowncommand (cmd/down.go) that first stops the workspace, then deletes it viaworkspace.Deletedevsy stopbehavior is unchanged — it still only stops the workspace