fix(log): make global logger thread-safe with atomic.Pointer#155
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 33 minutes and 22 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The global
sugarvariable inpkg/log/logger.gowas an unprotected*zap.SugaredLoggerpointer. Concurrent reads from log functions (e.g.log.Debug()in deferred calls inpkg/inject/inject.go) and writes from test cleanup (t.Cleanuprestoringsugarinpkg/log/testing.go) caused data races detected by Go's race detector in CI run 24964563286.The race was introduced by #147, which added
defer log.Debug(...)calls ininject.gothat fire after goroutines send to channels — creating concurrent access with test cleanup writing tosugar.This replaces the bare
*zap.SugaredLoggerpointer withatomic.Pointer[zap.SugaredLogger]. All reads go throughsugar.Load()and all writes throughsugar.Store(), making the global logger safe for concurrent access with zero behavioral changes.Files changed:
pkg/log/logger.go,pkg/log/testing.go,pkg/log/levels.go,pkg/log/writer.go