Skip to content

feat(config): support custom workspaceMount from devcontainer.json#170

Merged
skevetter merged 1 commit into
mainfrom
d226/workspace-mount
May 3, 2026
Merged

feat(config): support custom workspaceMount from devcontainer.json#170
skevetter merged 1 commit into
mainfrom
d226/workspace-mount

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Add test coverage for the custom workspaceMount property in devcontainer.json. The field was already parsed from config and wired through container creation (getWorkspace() in run.go checks conf.WorkspaceMount first, and config.go updates the substitution context). This PR adds 4 unit tests for getWorkspace() (custom mount, default mount, default with workspaceFolder, empty/unset) and 1 E2E test validating that a custom workspace mount target appears in the container's mount list.

Add unit tests for getWorkspace() covering custom mount, default mount,
default mount with workspaceFolder, and empty/unset workspaceMount.
Add E2E test validating custom workspace mount with testdata.

The workspaceMount field was already wired through config parsing and
container creation — this commit adds test coverage for the feature.
@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit f49530f
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f6ee5136deaa00085e613f

@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 3 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb26ea14-da25-4991-8efe-82c4470d0335

📥 Commits

Reviewing files that changed from the base of the PR and between 3ef60f9 and f49530f.

📒 Files selected for processing (3)
  • e2e/tests/up/provider_docker.go
  • e2e/tests/up/testdata/docker-workspace-mount/.devcontainer.json
  • pkg/devcontainer/run_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 25 minutes and 3 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/m label May 3, 2026
@skevetter
skevetter marked this pull request as ready for review May 3, 2026 06:54
@skevetter
skevetter enabled auto-merge (squash) May 3, 2026 06:54
@skevetter
skevetter merged commit a7794f0 into main May 3, 2026
51 checks passed
@skevetter
skevetter deleted the d226/workspace-mount branch May 3, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant