Skip to content

feat(devcontainer): add stopCompose shutdownAction for compose containers#186

Merged
skevetter merged 2 commits into
mainfrom
05b9/shutdown-action-stop-compose
May 4, 2026
Merged

feat(devcontainer): add stopCompose shutdownAction for compose containers#186
skevetter merged 2 commits into
mainfrom
05b9/shutdown-action-stop-compose

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Adds stopCompose as a distinct shutdownAction value per the devcontainer spec
  • Compose containers default to stopCompose (all services stopped); stopContainer only stops the individual container
  • Defines ShutdownActionNone, ShutdownActionStopContainer, ShutdownActionStopCompose constants, eliminating repeated string literals
  • Delete path unchanged — always tears down all compose services regardless of shutdownAction
  • Spec alignment: DEVSY-011 (P2 spec compliance)

@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit e08833b
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f7ddf6c2fcbc00083fd343

@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 18 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 03623414-b096-45a8-b1c5-c6faec13d8c8

📥 Commits

Reviewing files that changed from the base of the PR and between b51dbf6 and e08833b.

📒 Files selected for processing (12)
  • cmd/agent/container/daemon.go
  • cmd/agent/daemon.go
  • e2e/tests/up-docker-compose/helper.go
  • e2e/tests/up-docker-compose/testdata/docker-compose-shutdown-action-container/.devcontainer/devcontainer.json
  • e2e/tests/up-docker-compose/testdata/docker-compose-shutdown-action-container/docker-compose.yaml
  • e2e/tests/up-docker-compose/testdata/docker-compose-shutdown-action/.devcontainer/devcontainer.json
  • e2e/tests/up-docker-compose/testdata/docker-compose-shutdown-action/docker-compose.yaml
  • e2e/tests/up-docker-compose/up_docker_compose.go
  • pkg/daemon/agent/daemon.go
  • pkg/daemon/agent/daemon_test.go
  • pkg/devcontainer/config/config.go
  • pkg/devcontainer/delete.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 57 minutes and 18 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/m label May 3, 2026
…mpose containers

The devcontainer spec defines three shutdown actions: none, stopContainer,
and stopCompose. Previously devsy only distinguished none vs stop. Now
compose containers respect stopCompose (docker-compose stop all services)
vs stopContainer (stop only the individual container). The Delete() path
remains unchanged—it always tears down everything.
@skevetter
skevetter force-pushed the 05b9/shutdown-action-stop-compose branch from 41137b8 to a66ad08 Compare May 3, 2026 23:36
Verifies that shutdownAction: "stopCompose" stops all compose services
on devsy stop, and shutdownAction: "stopContainer" only stops the main
service container while leaving sidecars running.
@github-actions github-actions Bot added size/l and removed size/m labels May 3, 2026
@skevetter
skevetter enabled auto-merge (squash) May 4, 2026 01:51
@skevetter
skevetter merged commit 9ab288f into main May 4, 2026
53 checks passed
@skevetter
skevetter deleted the 05b9/shutdown-action-stop-compose branch May 4, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant