Skip to content

feat(config): derive devcontainerId from workspace folder per spec#195

Merged
skevetter merged 1 commit into
mainfrom
b511-80ea-devsy-012-devcontainer-id
May 4, 2026
Merged

feat(config): derive devcontainerId from workspace folder per spec#195
skevetter merged 1 commit into
mainfrom
b511-80ea-devsy-012-devcontainer-id

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Implements the devcontainer spec algorithm for devcontainerId variable substitution: SHA-256 hash of localWorkspaceFolder, truncated to 20 hex characters. The old label-based derivation is preserved as GetLegacyDevContainerID for backward compatibility, and a ResolveDevContainerID wrapper is provided for callers that need migration support.

The devcontainer spec requires devcontainerId to be derived from a
SHA-256 hash of the localWorkspaceFolder path, truncated to 20 hex
characters. Previously, GetDevContainerID hashed container labels which
didn't match the spec.

- Add DeriveDevContainerID(localWorkspaceFolder) implementing the spec
- Rename GetDevContainerID to GetLegacyDevContainerID for compat
- Add ResolveDevContainerID wrapper for migration callers
- Update substitution context to use spec-based derivation
@netlify

netlify Bot commented May 4, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 9273226
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f82b81d3984c0008f7ad38

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 48 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e203f81-8695-40f9-a45b-0e2eefbde532

📥 Commits

Reviewing files that changed from the base of the PR and between 8e1e7dd and 9273226.

📒 Files selected for processing (3)
  • pkg/devcontainer/config.go
  • pkg/devcontainer/config/substitute.go
  • pkg/devcontainer/config/substitute_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 16 minutes and 48 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter marked this pull request as ready for review May 4, 2026 05:15
@skevetter
skevetter enabled auto-merge (squash) May 4, 2026 05:15
@github-actions github-actions Bot added the size/m label May 4, 2026
@skevetter
skevetter merged commit d1895c5 into main May 4, 2026
53 checks passed
@skevetter
skevetter deleted the b511-80ea-devsy-012-devcontainer-id branch May 4, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant