Skip to content

feat(cmd): add --workspace-mount-consistency flag to up command#198

Merged
skevetter merged 3 commits into
mainfrom
feat/workspace-mount-consistency-flag
May 4, 2026
Merged

feat(cmd): add --workspace-mount-consistency flag to up command#198
skevetter merged 3 commits into
mainfrom
feat/workspace-mount-consistency-flag

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Adds a --workspace-mount-consistency CLI flag to the up command that allows users to specify the bind mount consistency mode (consistent, cached, or delegated) for the workspace mount. This is useful for macOS Docker users who want to tune filesystem performance vs. consistency trade-offs.

The flag value is appended to the workspace mount string as consistency=<value> when no consistency mode is already configured (respecting explicit values in devcontainer.json). Validation rejects invalid values at flag parse time.

Allow users to specify the bind mount consistency mode (consistent,
cached, delegated) for the workspace mount via CLI flag. The value is
appended to the workspace mount string when no consistency is already
configured.
@netlify

netlify Bot commented May 4, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit cd064ce
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f8440da5bdd80008b63b26

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 56 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2901bb7d-961c-4da5-a1b6-c77ff7bbffc7

📥 Commits

Reviewing files that changed from the base of the PR and between b79d806 and cd064ce.

📒 Files selected for processing (7)
  • cmd/up.go
  • cmd/up_test.go
  • pkg/devcontainer/config.go
  • pkg/devcontainer/config_test.go
  • pkg/devcontainer/run.go
  • pkg/devcontainer/run_test.go
  • pkg/provider/workspace.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 32 minutes and 56 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/m label May 4, 2026
On macOS, getWorkspace() injects consistency='consistent' as the default
before substitute() runs. The previous logic only appended when no
consistency value existed, causing the user's explicit
--workspace-mount-consistency flag to be silently ignored.

Now mountSetConsistency() replaces any existing consistency value when
the flag is set, and uses single-quoted values to match existing style.
@github-actions github-actions Bot added size/l and removed size/m labels May 4, 2026
@skevetter
skevetter marked this pull request as ready for review May 4, 2026 06:50
@skevetter
skevetter enabled auto-merge (squash) May 4, 2026 06:50
@skevetter
skevetter merged commit e2992f8 into main May 4, 2026
54 checks passed
@skevetter
skevetter deleted the feat/workspace-mount-consistency-flag branch May 4, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant