feat(cmd): add --workspace-mount-consistency flag to up command#198
Conversation
Allow users to specify the bind mount consistency mode (consistent, cached, delegated) for the workspace mount via CLI flag. The value is appended to the workspace mount string when no consistency is already configured.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 32 minutes and 56 seconds.Comment |
On macOS, getWorkspace() injects consistency='consistent' as the default before substitute() runs. The previous logic only appended when no consistency value existed, causing the user's explicit --workspace-mount-consistency flag to be silently ignored. Now mountSetConsistency() replaces any existing consistency value when the flag is set, and uses single-quoted values to match existing style.
Summary
Adds a
--workspace-mount-consistencyCLI flag to theupcommand that allows users to specify the bind mount consistency mode (consistent,cached, ordelegated) for the workspace mount. This is useful for macOS Docker users who want to tune filesystem performance vs. consistency trade-offs.The flag value is appended to the workspace mount string as
consistency=<value>when no consistency mode is already configured (respecting explicit values in devcontainer.json). Validation rejects invalid values at flag parse time.